unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Kanis <ivan@kanis.fr>
Cc: emacs-devel@gnu.org
Subject: Re: Source file not shown in help next to symbol
Date: Sun, 09 Aug 2015 18:07:59 +0300	[thread overview]
Message-ID: <83wpx4pkj4.fsf@gnu.org> (raw)
In-Reply-To: <87mvy03iqu.fsf@kanis.fr>

> From: Ivan Kanis <ivan@kanis.fr>
> Date: Sun, 09 Aug 2015 11:37:29 +0200
> Cc: Emacs Development List <emacs-devel@gnu.org>
> 
> August, 08 at 16:54 Stefan wrote:
> 
> >> I have this patch running for a while and it seems fine. I made the
> >> commit message today. I can push it if you think it's OK.
> >
> > Yes, please push it, I think it's OK, thank you.
> 
> OK it's done.

Thanks.  Please allow me a couple of minor comments about your log
entry:

    fix link to source code in help window
    ^^^
This should start with a capital F, as any English sentence.

    * lisp/help-fns.el (find-lisp-object-file-name): remove code that
                                                     ^^^^^^
Likewise.

    'No longer include timestamp in header of .elc files'. Add code
                                                         ^^
Two spaces between sentences, per US English conventions we use.



  reply	other threads:[~2015-08-09 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 15:12 Source file not shown in help next to symbol Ivan Kanis
2015-07-15 21:26 ` Stefan Monnier
2015-07-16 12:09   ` Ivan Kanis
2015-08-06 22:40     ` Stefan Monnier
2015-08-08  9:27       ` Ivan Kanis
2015-08-08 20:54         ` Stefan Monnier
2015-08-09  9:37           ` Ivan Kanis
2015-08-09 15:07             ` Eli Zaretskii [this message]
2015-08-10 12:50               ` Ivan Kanis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wpx4pkj4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ivan@kanis.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).