unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: master updated (e6041a0 -> 6220fae)
Date: Fri, 17 Feb 2017 17:26:12 +0200	[thread overview]
Message-ID: <83wpcorg8b.fsf@gnu.org> (raw)
In-Reply-To: <xa1tmvdkkh0r.fsf@mina86.com> (message from Michal Nazarewicz on Fri, 17 Feb 2017 15:51:00 +0100)

> From: Michal Nazarewicz <mina86@mina86.com>
> Date: Fri, 17 Feb 2017 15:51:00 +0100
> Cc: emacs-devel@gnu.org
> 
> On Fri, Feb 17 2017, Glenn Morris wrote:
> > Hi - this fails to bootstrap from a truly clean tree (probably you
> > need to "make extraclean" in an existing tree to see it).
> >
> > Ref: http://hydra.nixos.org/build/48774928
> >
> >   Loading lisp/international/characters.el (source)...
> >   Wrong type argument: char-table-p, nil
> 
> Unicode tables aren’t available and this causes the failure. ;/

I think they are not available because the uni-*.el files were not yet
produced.  Is that right?

If so, you could try conditioning the code on the availability of the
Unicode tables, because by the time characters.el is byte-compiled,
they will be.  And when we load characters.el as source, we hopefully
don't need syntax-table yet.

> I don’t fully comprehend how bootstrapping work just yet though.  In
> particular, characters.el has:
> 
>     (when (setq unicode-category-table
>                 (unicode-property-table-internal 'general-category))
>       (map-char-table #'(lambda (key val) …)
>                       unicode-category-table))
> 
> So perhaps it’s enough to hard-code syntax-table for ASCII and update
> the rest with similar conditional?

Yes.  But first I'd try not to hard-code anything at all.

Thanks.



  reply	other threads:[~2017-02-17 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170215164632.13342.86743@vcs0.savannah.gnu.org>
2017-02-17  5:26 ` master updated (e6041a0 -> 6220fae) Glenn Morris
2017-02-17 14:51   ` Michal Nazarewicz
2017-02-17 15:26     ` Eli Zaretskii [this message]
2017-02-17 15:43   ` Michal Nazarewicz
2017-02-17 16:33     ` Glenn Morris
2017-02-17 18:35       ` Michal Nazarewicz
2017-02-17 22:27         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wpcorg8b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mina86@mina86.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).