From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: libnettle/libhogweed WIP Date: Mon, 17 Apr 2017 21:11:30 +0300 Message-ID: <83wpaidhv1.fsf@gnu.org> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <83h91og80k.fsf@gnu.org> <87pogbuhoe.fsf@lifelogs.com> <834lxndmd9.fsf@gnu.org> <87efwrug6z.fsf@lifelogs.com> <831ssrdkmz.fsf@gnu.org> <8760i3ueev.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1492452685 20107 195.159.176.226 (17 Apr 2017 18:11:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 18:11:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 20:11:21 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0B7N-000509-On for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 20:11:17 +0200 Original-Received: from localhost ([::1]:38160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0B7S-0007yT-3r for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 14:11:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0B7M-0007yN-Qk for emacs-devel@gnu.org; Mon, 17 Apr 2017 14:11:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0B7J-0001uX-Gj for emacs-devel@gnu.org; Mon, 17 Apr 2017 14:11:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0B7J-0001uL-Dy for emacs-devel@gnu.org; Mon, 17 Apr 2017 14:11:13 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1853 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d0B7G-0000dX-PZ for emacs-devel@gnu.org; Mon, 17 Apr 2017 14:11:13 -0400 In-reply-to: <8760i3ueev.fsf@lifelogs.com> (message from Ted Zlatanov on Mon, 17 Apr 2017 13:34:00 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214087 Archived-At: > From: Ted Zlatanov > Date: Mon, 17 Apr 2017 13:34:00 -0400 > > USE_SAFE_ALLOCA; > unsigned char *storage = SAFE_ALLOCA (storage_length); > > gnutls.c: In function ‘gnutls_symmetric_aead’: > gnutls.c:1839:45: warning: pointer targets in passing argument 1 of ‘make_unibyte_string’ differ in signedness [-Wpointer-sign] > Lisp_Object output = make_unibyte_string (storage, storage_length); > ^~~~~~~ > In file included from gnutls.c:23:0: > lisp.h:3583:20: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ > extern Lisp_Object make_unibyte_string (const char *, ptrdiff_t); > ^~~~~~~~~~~~~~~~~~~ You need to declare/initialize 'storage' like this: char *storage = SAFE_ALLOCA (storage_length); > In file included from gnutls.c:23:0: > lisp.h:4425:47: warning: variable ‘sa_must_free’ set but not used [-Wunused-but-set-variable] > ptrdiff_t sa_count = SPECPDL_INDEX (); bool sa_must_free = false > ^ > gnutls.c:1769:3: note: in expansion of macro ‘USE_SAFE_ALLOCA’ > USE_SAFE_ALLOCA; > ^~~~~~~~~~~~~~~ > lisp.h:4425:13: warning: unused variable ‘sa_count’ [-Wunused-variable] > ptrdiff_t sa_count = SPECPDL_INDEX (); bool sa_must_free = false > ^ > gnutls.c:1769:3: note: in expansion of macro ‘USE_SAFE_ALLOCA’ > USE_SAFE_ALLOCA; > ^~~~~~~~~~~~~~~ Not sure why this happens: SAFE_FREE uses these variables. Perhaps because you didn't call SAFE_FREE before the first 'return'? Or maybe it's a side effect of the warning?