From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Date: Sun, 11 Mar 2018 20:13:59 +0200 Message-ID: <83woyiscns.fsf@gnu.org> References: <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520791969 20532 195.159.176.226 (11 Mar 2018 18:12:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2018 18:12:49 +0000 (UTC) Cc: charles@aurox.ch, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 11 19:12:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev5Se-0005Ep-4G for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2018 19:12:44 +0100 Original-Received: from localhost ([::1]:55186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev5Ug-0008UW-Vr for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2018 14:14:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev5U8-0008TS-6R for emacs-devel@gnu.org; Sun, 11 Mar 2018 14:14:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev5U3-0000L9-MG for emacs-devel@gnu.org; Sun, 11 Mar 2018 14:14:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev5Tp-0000AS-K0; Sun, 11 Mar 2018 14:13:57 -0400 Original-Received: from [176.228.60.248] (port=1613 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ev5Tn-000155-3E; Sun, 11 Mar 2018 14:13:56 -0400 In-reply-to: (message from Stefan Monnier on Sun, 11 Mar 2018 12:05:11 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223624 Archived-At: > From: Stefan Monnier > Date: Sun, 11 Mar 2018 12:05:11 -0400 > Cc: "Charles A. Roelli" > > > -DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5, 0, > > +DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5, > > + "(if (< (length mark-ring) 2)\ > > + (error \"Other region must be marked before transposing two regions\")\ > > + (let* ((num (if current-prefix-arg\ > > + (prefix-numeric-value current-prefix-arg)\ > > + 0))\ > > + (ring-length (length mark-ring))\ > > + (eltnum (mod num ring-length))\ > > + (eltnum2 (mod (1+ num) ring-length)))\ > > + (list (point) (mark) (elt mark-ring eltnum) (elt mark-ring eltnum2))))", > > Am I the only one who dislikes seeing such Elisp code hidden within our > C files? I have no problems with that.