From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Wed, 24 Oct 2018 22:09:11 +0300 Message-ID: <83woq7qi08.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <83si2f9ve4.fsf@gnu.org> <56889EC3.3040108@yandex.ru> <877fjrkpdf.fsf@fencepost.gnu.org> <56892334.4000106@yandex.ru> <8760zakb7q.fsf@fencepost.gnu.org> <56892BDA.6060103@dancol.org> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <1249c6c5-6ff6-8b1e-102f-0b1b0942a42e@gmail.com> <83bm7js5ba.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540408075 9050 195.159.176.226 (24 Oct 2018 19:07:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2018 19:07:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 24 21:07:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFOVS-0002Eu-3F for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2018 21:07:50 +0200 Original-Received: from localhost ([::1]:49939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFOXY-0000BU-N0 for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2018 15:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFOWw-0008Ib-Ty for emacs-devel@gnu.org; Wed, 24 Oct 2018 15:09:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFOWq-000670-5Z for emacs-devel@gnu.org; Wed, 24 Oct 2018 15:09:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFOWo-00065h-9D; Wed, 24 Oct 2018 15:09:14 -0400 Original-Received: from [176.228.60.248] (port=4769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFOWn-0007BJ-P1; Wed, 24 Oct 2018 15:09:14 -0400 In-reply-to: (message from =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel on Wed, 24 Oct 2018 15:00:46 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230644 Archived-At: > Cc: emacs-devel@gnu.org > From: Clément Pit-Claudel > Date: Wed, 24 Oct 2018 15:00:46 -0400 > > For large collections, I imagine you would use a hashtable? I doubt that you will see in practice collections that are so long that assoc is too slow. > > Please don't forget those who will read your code. A code is written > > once, but read many times. It should be readable and > > self-explanatory. > > Of course. Note that I mentioned reading the pcase forms, not writing them. I'm just pointing out that there are readers who find pcase more readable than either assoc or cond with eq tests. I think the complicated quoting (frequently used incorrectly) of pcase makes it harder to read for at least some, if nothing else, because they need to waste time trying to understand what is the reason for using those quotes. I know it happened to me.