From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 30 Oct 2018 14:38:23 +0200 Message-ID: <83wopzk3sw.fsf@gnu.org> References: <83tvlcsnee.fsf@gnu.org> <86mur137n8.fsf@gmail.com> <20181029130132.GB4195@ACM> <20181029134722.GC4195@ACM> <83r2g8klf9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540902990 22487 195.159.176.226 (30 Oct 2018 12:36:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 12:36:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 30 13:36:26 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHTFw-0005in-D5 for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 13:36:24 +0100 Original-Received: from localhost ([::1]:52964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHTI2-00016Z-VC for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 08:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHTHn-00013l-HB for emacs-devel@gnu.org; Tue, 30 Oct 2018 08:38:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHTHh-0005SO-1o for emacs-devel@gnu.org; Tue, 30 Oct 2018 08:38:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHTHg-0005SF-UR; Tue, 30 Oct 2018 08:38:12 -0400 Original-Received: from [176.228.60.248] (port=3104 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gHTHg-0003UF-39; Tue, 30 Oct 2018 08:38:12 -0400 In-reply-to: (message from Stefan Monnier on Tue, 30 Oct 2018 08:15:31 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230821 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 30 Oct 2018 08:15:31 -0400 > > > I think the doc string should be (more) independent, at least in the > > pcase-dolist case, because the semantics of executing BODY with > > PATTERN matched against a LIST element is significantly different from > > that of executing the dolist BODY with a VAR binding. > > Hmm... I really don't see what difference you're thinking of. I thought it was clear: matching doesn't assign any values to anything directly related to BODY, so the mechanism by which it affects execution of BODY needs to be described. > Maybe a simpler way to document it is to show its definition: > > (dolist (x LIST) (pcase-let ((PATTERN x)) BODY)) You aren't saying that showing the code removes the need for any documentation of what it does, do you? ;-)