From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 08 Feb 2019 15:14:30 +0200 Message-ID: <83womapgll.fsf@gnu.org> References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> <83zhr6pqmr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41742"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 14:15:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gs5zs-000AdZ-SS for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 14:15:12 +0100 Original-Received: from localhost ([127.0.0.1]:56446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs5zr-0007sf-OJ for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 08:15:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs5zc-0007kc-Jj for emacs-devel@gnu.org; Fri, 08 Feb 2019 08:14:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs5zc-0006YZ-Hy; Fri, 08 Feb 2019 08:14:56 -0500 Original-Received: from [176.228.60.248] (port=3488 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gs5za-00007W-8F; Fri, 08 Feb 2019 08:14:56 -0500 In-reply-to: (message from Robert Pluim on Fri, 08 Feb 2019 12:46:32 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233120 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Fri, 08 Feb 2019 12:46:32 +0100 > > >> ./configure # This builds xfont.o ftfont.o xftfont.o ftxfont.o > > > > I wonder why we build both xftfont.o and ftxfont.o, when we only use > > one of them, if my reading of the code is correct. > > > > I did suggest removing ftxfont.o, but you said we had to deprecate it > first. Itʼs easy enough to not build in the HAVE_XFT config. That's orthogonal. Regardless of whether we want to drop ftxfont.c, I don't understand why build with both xftfont.c and ftxfont.c. They seem to be mutually exclusive, from the end-user POV. > >> I can cherry-pick this to the harfbuzz branch if you want. > > > > Thanks, please do. > > Will do. TIA