From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: Fixing some warnings in emacs-26
Date: Sat, 08 Jun 2019 11:51:23 +0300 [thread overview]
Message-ID: <83wohwo3xw.fsf@gnu.org> (raw)
In-Reply-To: <m2ftokv64k.fsf@linux-m68k.org> (message from Andreas Schwab on Sat, 08 Jun 2019 10:22:19 +0200)
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sat, 08 Jun 2019 10:22:19 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> > - char msg[ MAX_PATH ];
> > + char msg[ MAX_PATH + 20 ]; /* Needs extra space for fixed text. */
> > sprintf (msg, "Install Emacs at %s?\n", emacs_path);
>
> emacs_path can be longer than MAX_PATH.
Not in the branch where the above code is used, I think. In that
branch, emacs_path comes from the GetModuleFileName call, and we limit
the result from that call to MAX_PATH characters.
next prev parent reply other threads:[~2019-06-08 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 5:11 Fixing some warnings in emacs-26 Juanma Barranquero
2019-06-08 6:41 ` Eli Zaretskii
2019-06-08 7:07 ` Juanma Barranquero
2019-06-08 8:43 ` Eli Zaretskii
2019-06-08 22:55 ` Juanma Barranquero
2019-06-09 6:12 ` Eli Zaretskii
2019-06-08 8:22 ` Andreas Schwab
2019-06-08 8:51 ` Eli Zaretskii [this message]
2019-06-09 11:02 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wohwo3xw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).