From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: string_char_to_byte and string_byte_to_char micro-optimisation
Date: Fri, 14 Jun 2019 22:00:40 +0300
Message-ID: <83wohovvon.fsf@gnu.org>
References: <m28su41gwp.fsf@gmail.com>
 <b7788422-ec36-20ea-1a8e-28f2cf0f6109@cs.ucla.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="194125"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Paul Eggert <eggert@cs.ucla.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 21:12:42 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbrcu-000oBV-5Y
	for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 21:12:40 +0200
Original-Received: from localhost ([::1]:54501 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbrcm-0006Nh-Pk
	for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 15:12:32 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34602)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hbrRG-0000bH-KI
 for emacs-devel@gnu.org; Fri, 14 Jun 2019 15:00:42 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47295)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hbrRG-00051q-0X; Fri, 14 Jun 2019 15:00:38 -0400
Original-Received: from [176.228.60.248] (port=2238 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hbrRE-0004KI-OB; Fri, 14 Jun 2019 15:00:37 -0400
In-reply-to: <b7788422-ec36-20ea-1a8e-28f2cf0f6109@cs.ucla.edu> (message from
 Paul Eggert on Fri, 14 Jun 2019 09:53:50 -0700)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:237635
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/237635>

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 14 Jun 2019 09:53:50 -0700
> 
> On 6/14/19 5:37 AM, Robert Pluim wrote:
> > What I donʼt have is any intuition on whether such a change actually
> > makes any difference in real-world Emacs usage. Can anyone suggest any
> > benchmarks?
> 
> My usual benchmark for this sort of thing is 'make compile-always' in 
> the lisp directory.

I don't think that will do for this case.  Strings are used rather
rarely in Emacs.  We need to find a command that uses strings
extensively, and uses non-ASCII text in strings in particular.  Some
JSON processing with non-ASCII strings inside, perhaps?