From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Fri, 13 Sep 2019 11:50:02 +0300 Message-ID: <83woeczikl.fsf@gnu.org> References: <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <377a8380-af26-776f-de79-2e24cc14e0e4@gmx.at> <20190908125306.mhb2eg7nxjs5z5pf@Ergus> <36b5122a-96a7-b798-1fed-423ea388b772@gmx.at> <83k1ah31fj.fsf@gnu.org> <20190909170826.w3ug6iv3fnrxh4jp@Ergus> <83d0g92vgs.fsf@gnu.org> <20190909192934.7sysej7ladlefunb@Ergus> <838sqw3mxw.fsf@gnu.org> <20190912033733.rt6ebux3424n2vbi@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="97510"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 13 10:49:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8hHB-000PDx-SW for ged-emacs-devel@m.gmane.org; Fri, 13 Sep 2019 10:49:57 +0200 Original-Received: from localhost ([::1]:41400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8hHA-0006KL-ON for ged-emacs-devel@m.gmane.org; Fri, 13 Sep 2019 04:49:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48305) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8hH3-0006K7-At for emacs-devel@gnu.org; Fri, 13 Sep 2019 04:49:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i8hH2-0005wz-TZ; Fri, 13 Sep 2019 04:49:48 -0400 Original-Received: from [176.228.60.248] (port=3321 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i8hH1-0007hL-VA; Fri, 13 Sep 2019 04:49:48 -0400 In-reply-to: <20190912033733.rt6ebux3424n2vbi@Ergus> (message from Ergus on Thu, 12 Sep 2019 05:37:33 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240012 Archived-At: > Date: Thu, 12 Sep 2019 05:37:33 +0200 > From: Ergus > Cc: rudalics@gmx.at, emacs-devel@gnu.org > > Hi Eli: > > Could you answer please the questions about the modifications in other > functions (face_at_string and so on)? Sorry, I probably lost context, because I cannot figure out which questions are those. Could you please repeat them? > And could you tell me which are the faces that are supposed to be > :extend t by default. I think 'default', 'region', and 'hl-line'. > I made a couple of changes in the interface to avoid passing the values > by reference. And other small fixed in the branch. Please give a look > and tell me what do you think. Will do. > It will be nice if you could tell me where in the manual I am supposed > to documents this as this actually enables 2 different functionalities: > > 1) Extend a face. > 2) Change the region looking (whole screen width or "fixed to text" as a > side effect). > > And fixes the issues with fill-column-indicator in org and the other > issue that martin indicated. I think the right place is in "Face Attributes". > So after that; your comments and the documentations I think I will > rename the branch to a feature one in order to suggest people to test it > your recommended two weeks. I don't see a reason for renaming the branch, you could leave it as is. Thanks.