From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Emacs regexp scan (Sep 29)
Date: Sun, 06 Oct 2019 21:01:25 +0300 [thread overview]
Message-ID: <83wodh21oq.fsf@gnu.org> (raw)
In-Reply-To: <jwv7e5irnyn.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 06 Oct 2019 09:42:31 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: eggert@cs.ucla.edu, mattiase@acm.org, emacs-devel@gnu.org
> Date: Sun, 06 Oct 2019 09:42:31 -0400
>
> > That's unrelated. I was talking about modifying _existing_ code, not
> > about writing new code.
>
> In my experience, a lot of new code is written by looking at old code
> (witness all the quoted lambdas around that can be found in "new" code).
Which is why we have code reviews. Witness the many messages by
yourself and others that comment on those practices we are unhappy
about.
next prev parent reply other threads:[~2019-10-06 18:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 19:39 Emacs regexp scan (Sep 29) Mattias Engdegård
2019-10-04 21:42 ` Paul Eggert
2019-10-05 8:10 ` Eli Zaretskii
2019-10-05 9:37 ` Mattias Engdegård
2019-10-05 10:49 ` Eli Zaretskii
2019-10-05 15:16 ` Stefan Monnier
2019-10-05 16:02 ` Eli Zaretskii
2019-10-05 9:52 ` Paul Eggert
2019-10-05 10:59 ` Eli Zaretskii
2019-10-05 15:20 ` Stefan Monnier
2019-10-05 16:03 ` Eli Zaretskii
2019-10-06 13:42 ` Stefan Monnier
2019-10-06 18:01 ` Eli Zaretskii [this message]
2019-10-05 19:19 ` Paul Eggert
2019-10-05 19:31 ` Eli Zaretskii
2019-10-05 19:50 ` Paul Eggert
2019-10-06 17:19 ` Eli Zaretskii
2019-10-06 17:33 ` Paul Eggert
2019-10-06 18:53 ` Eli Zaretskii
2019-10-06 19:19 ` Paul Eggert
2019-10-06 19:31 ` Eli Zaretskii
2019-10-05 16:59 ` Lars Ingebrigtsen
2019-10-05 18:52 ` Paul Eggert
2019-10-05 10:03 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wodh21oq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).