From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049. Date: Thu, 14 Nov 2019 18:12:31 +0200 Message-ID: <83woc24ets.fsf@gnu.org> References: <20191109144026.20810.76129@vcs0.savannah.gnu.org> <20191109144027.DDC3720927@vcs0.savannah.gnu.org> <38328d99-23c8-7ba7-a23d-e70ac0aab67a@yandex.ru> <20191111203445.GA5135@ACM> <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> <20191113211936.GB4942@ACM> <6fc930a1-eb47-9e54-8752-8cf7ff041586@yandex.ru> <03042d05-2160-77c4-9abd-b0f13f638247@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170928"; mail-complaints-to="usenet@blaine.gmane.org" Cc: acm@muc.de, emacs-devel@gnu.org, dgutov@yandex.ru To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 17:13:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVHka-000iLM-9q for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 17:13:40 +0100 Original-Received: from localhost ([::1]:59274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVHkZ-00031g-2i for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 11:13:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42259) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVHjm-00031a-S2 for emacs-devel@gnu.org; Thu, 14 Nov 2019 11:12:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVHjl-0002Eo-Jo; Thu, 14 Nov 2019 11:12:49 -0500 Original-Received: from [176.228.60.248] (port=4438 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVHjj-0007O7-D1; Thu, 14 Nov 2019 11:12:48 -0500 In-reply-to: (message from Stefan Monnier on Thu, 14 Nov 2019 09:55:58 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242186 Archived-At: > From: Stefan Monnier > Date: Thu, 14 Nov 2019 09:55:58 -0500 > Cc: Alan Mackenzie , emacs-devel@gnu.org > > Also, I think I'm beginning to understand: the issue is that > vertical-motion uses the redisplay code, which in turn calls jit-lock > when needed. Yes. > So, your earlier patch which added a call to `font-lock-ensure` was > "more or less right", except that it should have used > `jit-lock-ensure` (currently called `jit-lock-fontify-now`) and > could have a comment explaining that vertical-motion will trigger > jit-lock anyway so it's better to do it once beforehand on the whole > region, not only so it can be done outside of the narrowing but also > so it can be done more efficiently than one jit-lock-chunk-size at a > time. I'd like to solve this in CC mode instead, because the problem is there. Fontifying arbitrary portions of the buffer to indirectly avoid triggering the problem in CC mode sounds not TRT to me. In particular, what if the POINT-MIN..END chunk is still too large to fontify in one go?