From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Two patches for mairix.el Date: Sat, 01 May 2021 17:40:41 +0300 Message-ID: <83wnsi8ql2.fsf@gnu.org> References: <87sg36le5o.fsf@dsemy.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24508"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daniel Semyonov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 01 16:41:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcqoC-0006Il-U4 for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 16:41:28 +0200 Original-Received: from localhost ([::1]:51816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcqoB-000714-TV for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 10:41:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcqne-0006X2-NW for emacs-devel@gnu.org; Sat, 01 May 2021 10:40:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44059) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcqnd-0006vL-A9; Sat, 01 May 2021 10:40:53 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1234 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lcqnZ-0001Fx-NE; Sat, 01 May 2021 10:40:50 -0400 In-Reply-To: <87sg36le5o.fsf@dsemy.com> (message from Daniel Semyonov on Sat, 01 May 2021 17:30:43 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268714 Archived-At: > From: Daniel Semyonov > Date: Sat, 01 May 2021 17:30:43 +0300 > > I've recently begun to use Emacs' interface for mairix(1) for indexing > and searching through my mail, and have noticed two small issues. > > The first one is that the main interactive entry points for mairix.el > aren't autoloaded (I'm guessing the present mechanism for autoloading > wasn't available when it was written?). The first patch adds appropriate > ';;;###autoload' lines before commands which can serve as such. > > The second is that `mairix-search-options' isn't actually used, even > though both the manual and the docstring seem to indicate that it should > be. The second patch modifies `mairix-call-mairix' slightly to add the options > specified. > > Note: I haven't completed copyright assignment yet (I need to get a > disclaimer from my university still, might take a while), but I hope > those changes are trivial enough to be accepted without it. The changes are indeed small enough for us to accept them, but could you please reformat the log message(s) according to our conventions? You will find the conventions described in CONTRIBUTE, and I suggest to use "git log" to look at the log messages as examples. Thanks.