unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Semyonov <cmstr@dsemy.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Two patches for mairix.el
Date: Sat, 01 May 2021 17:40:41 +0300	[thread overview]
Message-ID: <83wnsi8ql2.fsf@gnu.org> (raw)
In-Reply-To: <87sg36le5o.fsf@dsemy.com> (message from Daniel Semyonov on Sat,  01 May 2021 17:30:43 +0300)

> From: Daniel Semyonov <cmstr@dsemy.com>
> Date: Sat, 01 May 2021 17:30:43 +0300
> 
> I've recently begun to use Emacs' interface for mairix(1) for indexing
> and searching through my mail, and have noticed two small issues.
> 
> The first one is that the main interactive entry points for mairix.el
> aren't autoloaded (I'm guessing the present mechanism for autoloading
> wasn't available when it was written?). The first patch adds appropriate
> ';;;###autoload' lines before commands which can serve as such.
> 
> The second is that `mairix-search-options' isn't actually used, even
> though both the manual and the docstring seem to indicate that it should
> be. The second patch modifies `mairix-call-mairix' slightly to add the options
> specified.
> 
> Note: I haven't completed copyright assignment yet (I need to get a
> disclaimer from my university still, might take a while), but I hope
> those changes are trivial enough to be accepted without it.

The changes are indeed small enough for us to accept them, but could
you please reformat the log message(s) according to our conventions?
You will find the conventions described in CONTRIBUTE, and I suggest
to use "git log" to look at the log messages as examples.

Thanks.



  reply	other threads:[~2021-05-01 14:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 14:30 [PATCH] Two patches for mairix.el Daniel Semyonov
2021-05-01 14:40 ` Eli Zaretskii [this message]
2021-05-01 15:19   ` Daniel Semyonov
2021-05-01 15:29     ` Eli Zaretskii
2021-05-15  8:13       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wnsi8ql2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cmstr@dsemy.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).