From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Wed, 05 May 2021 14:56:28 +0300
Message-ID: <83wnsd2y37.fsf@gnu.org>
References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org>
 <CADwFkm=cX6--3fb44giy5PY4htCWv+CrCmc2uos3rmmMs4HHUA@mail.gmail.com>
 <835z006jpl.fsf@gnu.org>
 <CADwFkmmyL7-gcArU5kuM6aQMgmxoHB+YvQv0pXM9USCsphta1w@mail.gmail.com>
 <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org>
 <87mtt9sqh4.fsf@red-bean.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="15745"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Karl Fogel <kfogel@red-bean.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 05 13:58:20 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1leGAW-0003yR-7g
	for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 13:58:20 +0200
Original-Received: from localhost ([::1]:52578 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1leGAV-00085n-8r
	for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 07:58:19 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60240)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1leG8w-000570-6K
 for emacs-devel@gnu.org; Wed, 05 May 2021 07:56:42 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42557)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1leG8v-0002kv-Nc; Wed, 05 May 2021 07:56:41 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2026
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1leG8u-0004I8-D8; Wed, 05 May 2021 07:56:41 -0400
In-Reply-To: <87mtt9sqh4.fsf@red-bean.com> (message from Karl Fogel on Wed, 05
 May 2021 00:24:07 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:268906
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/268906>

> From: Karl Fogel <kfogel@red-bean.com>
> Date: Wed, 05 May 2021 00:24:07 -0500
> 
> Revised patch attached, with the option now defaulting to nil 
> (i.e., to the old behavior) as per discussion.  Review/comments 
> welcome.

Thanks, LGTM, modulo Lars's comments (with which I agree) about the
doc string.