From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: macOS metal rendering engine in mac port Date: Sat, 29 May 2021 12:37:00 +0300 Message-ID: <83wnrh6fur.fsf@gnu.org> References: <83k0ni6pje.fsf@gnu.org> <83eedq6mvm.fsf@gnu.org> <83y2bx6gct.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: aaronjensen@gmail.com, emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 29 11:37:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmvPH-0005OX-TE for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 11:37:23 +0200 Original-Received: from localhost ([::1]:58688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmvPG-0007HN-TY for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 05:37:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmvOn-0006cs-G6 for emacs-devel@gnu.org; Sat, 29 May 2021 05:36:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39616) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmvOm-0003Hb-Ob; Sat, 29 May 2021 05:36:52 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1425 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmvOm-0007It-Bb; Sat, 29 May 2021 05:36:52 -0400 In-Reply-To: (message from Alan Third on Sat, 29 May 2021 10:32:00 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270045 Archived-At: > Date: Sat, 29 May 2021 10:32:00 +0100 > From: Alan Third > Cc: aaronjensen@gmail.com, emacs-devel@gnu.org > > Yes, I think that's what I'm talking about. There's a lot of code like this: > > struct face *face = FRAME_DEFAULT_FACE (f); > [ns_lookup_indexed_color (NS_FACE_BACKGROUND (face), f) set]; > > and > > if (s->hl == DRAW_MOUSE_FACE) > { > face = FACE_FROM_ID_OR_NULL (s->f, > MOUSE_HL_INFO (s->f)->mouse_face_face_id); > if (!face) > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); > } > else > face = s->face; > > Which I don't think is present in the other terms, because, as I say, > they look them up in one function rather than spread out throughout > the term's code. I cannot see why this would be a problem. First, FACE_FROM_ID and FACE_FROM_ID_OR_NULL simply access a face by direct indexing into the frame's face cache, so it's just a couple of CPU instructions. And second, I see very similar code in other *term.c sources, so I don't think nsterm.m does it very differently. > But again, I don't think this should recalculate anything. Macros like > FACE_FROM_ID_OR_NULL appear to be doing simple lookups that shouldn't > slow anything down, unless I'm missing something. Exactly.