From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos
 encoding
Date: Mon, 16 Aug 2021 14:32:03 +0300
Message-ID: <83wnol8w24.fsf@gnu.org>
References: <CA+G3_PPNdCS8QWtemUuZ1LgwcwaLc=YLnSokcU9u9zc=OG+U7A@mail.gmail.com>
 <87o89ygyu8.fsf@gnus.org>
 <CA+G3_PORBJ9RcBmNBpix-d2b_B-FRVgohmawyOjMfDFmxN7VQw@mail.gmail.com>
 <CA+G3_PP+Hm0QQchsznLzVFLvgsR5QcxpKY6umNCzPuAUdNX0pw@mail.gmail.com>
 <CA+G3_PNw+LNUhU8Kk1wA4EtL_mUcLp69eFrdW5S2Py=hjRsbwQ@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21591"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: larsi@gnus.org, emacs-devel@gnu.org
To: Tom Gillespie <tgbugs@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 13:33:26 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mFaru-0005QQ-Qe
	for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 13:33:26 +0200
Original-Received: from localhost ([::1]:57992 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1mFart-000472-2N
	for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 07:33:25 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50430)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1mFaqh-0002dJ-Ks
 for emacs-devel@gnu.org; Mon, 16 Aug 2021 07:32:11 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44366)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1mFaqh-0002vY-AV; Mon, 16 Aug 2021 07:32:11 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1182
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1mFaqg-0001HP-T4; Mon, 16 Aug 2021 07:32:11 -0400
In-Reply-To: <CA+G3_PNw+LNUhU8Kk1wA4EtL_mUcLp69eFrdW5S2Py=hjRsbwQ@mail.gmail.com>
 (message from Tom Gillespie on Sun, 15 Aug 2021 16:09:33 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:272427
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/272427>

> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Sun, 15 Aug 2021 16:09:33 -0700
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Here is an updated version of the patch that
> removes the conversion line and adds a test
> for find-file to make sure that nothing unexpected
> is happening. Best,

Could we please step back a notch?  I don't think I understand the
problem you are trying to solve, so could you please describe it in
more detail?  Without a sufficiently good understanding of the issue
you are trying to solve, I cannot make up my mind whether your
proposed solution is the best one.

TIA