From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: XInput 2 support (again)
Date: Sun, 14 Nov 2021 18:12:02 +0200 [thread overview]
Message-ID: <83wnlau371.fsf@gnu.org> (raw)
In-Reply-To: <jwvy25qvjwv.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 14 Nov 2021 10:29:02 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Po Lu via "Emacs development discussions." <emacs-devel@gnu.org>
> Date: Sun, 14 Nov 2021 10:29:02 -0500
>
> >> A lot of it is copy&pasted from other parts of `handle_one_xevent`.
> >> Please avoid such code duplication (`handle_one_xevent` is already bad
> >> enough from this point of view).
> >
> > I don't know enough about most of the Core Input code to dare change it.
> > It does mysterious things that I can not understand.
> >
> > Also, most of the XInput 2 event code differs in subtle ways from the
> > Core Input code (see for example how the button grab is handled there).
> >
> > It would make even more of a mess to try to reuse the Core Input
>
> I'll let Eli&Lars decide if they're OK with it (after all, we have
> a lot of such code duplication between the various
> x/w32/ns/.. backends), but I think I'd like to see a unified version of
> the code before deciding that the copy&paste is indeed a better option.
I had the same comment when this patch was first posted. Po Lu says
it's infeasible for him to make it less repetitive.
next prev parent reply other threads:[~2021-11-14 16:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87v90wmh6m.fsf.ref@yahoo.com>
2021-11-13 11:24 ` XInput 2 support (again) Po Lu via Emacs development discussions.
2021-11-13 15:04 ` Stefan Monnier
2021-11-14 1:29 ` Po Lu via Emacs development discussions.
2021-11-14 15:29 ` Stefan Monnier
2021-11-14 16:12 ` Eli Zaretskii [this message]
2021-11-14 18:11 ` Stefan Monnier
2021-11-14 18:51 ` Eli Zaretskii
2021-11-15 0:26 ` Po Lu
2021-11-15 2:48 ` Stefan Monnier
2021-11-15 2:54 ` Po Lu
2021-11-15 3:18 ` Stefan Monnier
2021-11-15 4:50 ` Po Lu
2021-12-07 17:23 ` Possible XInput2 cursor bug ? (Was: Re: XInput 2 support (again)) Madhu
2021-12-08 1:27 ` Possible XInput2 cursor bug ? Po Lu
2021-12-08 2:33 ` Madhu
2021-12-08 2:39 ` Po Lu
2021-12-12 5:11 ` Madhu
2021-12-12 5:27 ` Po Lu
2021-12-12 6:02 ` Po Lu
2021-12-12 14:45 ` Madhu
2021-12-13 1:21 ` Po Lu
2021-12-13 4:18 ` Madhu
2021-12-12 7:26 ` Eli Zaretskii
2021-12-12 14:55 ` Madhu
2021-12-12 15:08 ` Eli Zaretskii
2021-12-12 18:15 ` Madhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnlau371.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).