From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: sqlite3 Date: Sun, 19 Dec 2021 13:14:24 +0200 Message-ID: <83wnk0978v.fsf@gnu.org> References: <87tufmjyai.fsf@gnus.org> <87mtl13vz2.fsf@gnus.org> <87ilvp3tzo.fsf@gnus.org> <83wnk5gduf.fsf@gnu.org> <87r1ab1y0r.fsf@gnus.org> <83sfurejs6.fsf@gnu.org> <871r2b1vu8.fsf@gnus.org> <83o85feitv.fsf@gnu.org> <87lf0jzifm.fsf@gnus.org> <83a6gze705.fsf@gnu.org> <87k0g2xsu9.fsf@gnus.org> <83v8zmb6pi.fsf@gnu.org> <87k0g0yicx.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39525"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 19 12:17:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myuBn-000A1j-59 for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 12:17:15 +0100 Original-Received: from localhost ([::1]:33894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myuBl-0007uP-PO for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Dec 2021 06:17:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myu9I-0006LF-Kd for emacs-devel@gnu.org; Sun, 19 Dec 2021 06:14:40 -0500 Original-Received: from [2001:470:142:3::e] (port=58736 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myu9I-0005LC-59; Sun, 19 Dec 2021 06:14:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HUXIgF9NmbPeqTlZwWEGljdNJJ5gJCUkVZlu5MeV/jE=; b=NBEVskr+jb/W fY2+3/sLnz1ni2/tb6CBn26IV227Ai1uQq8WB7qw6ox5RXKbxwtVtzV8y0zjQg9jDOPSaazgRVFne 3IXP9/QAQ64D3y1MqDxP5w0O0lLZnDW+AKfYUK0qm6Pjm1dS4FGRGxPj41PffUViVfJZc4GPeghUF reYf3fAuRt8pk/5M5yCMNceNyxQq8lXLbpECacmBem6KYb0nGmCufuu/zu/nrN/j7F5CrRYKSUR98 Xn/zg/ZJpuUo1bNXP5V0c5/i8hefB3gQY8himnUDKCNm3flGh1sykBjUMLwJBIihp6NbRr5jCRmSX Fm4A/Y+d4PV4e0mxL45GYg==; Original-Received: from [87.69.77.57] (port=2316 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myu9B-0007no-9c; Sun, 19 Dec 2021 06:14:36 -0500 In-Reply-To: <87k0g0yicx.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 19 Dec 2021 11:55:10 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282409 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Sun, 19 Dec 2021 11:55:10 +0100 > > > I think fsync should be necessary because we use temporary files, and > > those are by default not fsync'ed when we close the descriptor to > > which we wrote. At least on MS-Windows, I think this could mean other > > processes might get a stale file contents. > > Right. Perhaps we should consider doing this without the rename on > Windows? (And without fsync on non-Windows.) If you show me a patch, I can try it.