From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Incorrect font weight selected Date: Thu, 06 Jan 2022 09:09:36 +0200 Message-ID: <83wnjd8hn3.fsf@gnu.org> References: <87pmpv708h.fsf@wavexx.thregr.org> <83r1abcb93.fsf@gnu.org> <87y24jqahr.fsf@wavexx.thregr.org> <83ilvnc6z4.fsf@gnu.org> <875yrmyk8q.fsf@wavexx.thregr.org> <87y24grwp6.fsf@wavexx.thregr.org> <877dbzo98z.fsf@gnus.org> <83bl1b12b5.fsf@gnu.org> <837dbz112w.fsf@gnu.org> <71a9cd97-02a6-79d7-6af8-b4aef3d1baa8@yandex.ru> <83y24eyww3.fsf@gnu.org> <87wnjyt9yd.fsf@wavexx.thregr.org> <83sfumyr9c.fsf@gnu.org> <877dbe86tv.fsf@wavexx.thregr.org> <83ee5m9kp7.fsf@gnu.org> <87r19mulkg.fsf@wavexx.thregr.org> <83bl0q9hz6.fsf@gnu.org> <87mtkaujbs.fsf@wavexx.thregr.org> <838rvu9f35.fsf@gnu.org> <877dbdvjga.fsf@wavexx.thregr.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 06 08:12:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5Mwe-0002jK-Fs for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 08:12:20 +0100 Original-Received: from localhost ([::1]:37216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Mwd-0007Bj-CP for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 02:12:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Mtp-0005l4-Rx for emacs-devel@gnu.org; Thu, 06 Jan 2022 02:09:26 -0500 Original-Received: from [2001:470:142:3::e] (port=36112 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Mto-0007NU-SX; Thu, 06 Jan 2022 02:09:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FmK55Kwq+1mE4LAJK7jp/H2GrwderPYZCTBkxPN9v90=; b=B+nloKFmRTE/ OMpeyEWFmXrS7H5bsQ0jKI2BGTEJLx8J9GCMjA76ha8nebgyefLTS1oIPYz9GB5lWNu5LbtJXjRcs FFWblcKxwwGe0dZz1OelK6xi2kOtuCjfzLd8P8He/zT04vWfwNSC8spXG2BNCy4O66c6PqAFA9+9K Aq019cyH1/kVvIBHwzVKdysoS32dR66Z1Og+Jg/Bfhh9k7+NKRnNeEf7guw16rwL/8121oYOvBri6 uP7XVClO0FmaremxScwjvKipd0EelNSGu+NK+LRzHb3Tn/yYyBrfJqTcncNbGQe8CEOXVmLtJSwLf PcfkL8kvFgCQwAzFQUxDoA==; Original-Received: from [87.69.77.57] (port=3717 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Mto-0003xa-HH; Thu, 06 Jan 2022 02:09:25 -0500 In-Reply-To: <877dbdvjga.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Thu, 06 Jan 2022 00:16:15 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284287 Archived-At: > From: Yuri D'Elia > Cc: dgutov@yandex.ru, monnier@iro.umontreal.ca, larsi@gnus.org, > emacs-devel@gnu.org > Date: Thu, 06 Jan 2022 00:16:15 +0100 > > On Wed, Jan 05 2022, Eli Zaretskii wrote: > > When we look at low-level code such as this one, we should always keep > > that in mind, and avoid leaking the face definitions to other frames. > > The trick of making the change take effect on other frames is > > implemented by higher levels. > > Do you have a more concrete overview of how the change _should_ at least > ideally be propagated for me to get a better overview? Sorry, I don't think I understand what kind of overview are you asking for. Please tell more. > > This is the general background that makes me uneasy to accept the > > changes which you suggested, because they seem to violate that general > > principle on a very low level. > > In this sense, the change only fixes the lower-level font selection when > opening a face in a single frame, so it doesn't alter how we're > propagating the change at all at the moment. But in doing so, it uses a font spec that came from another frame, does it not?