From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat' Date: Sun, 17 Apr 2022 22:12:10 +0300 Message-ID: <83wnfnwmlx.fsf@gnu.org> References: <7C193269-26F7-4E85-A1E6-7A3C0C1DECC6@acm.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34652"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, esq@lawlist.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 17 21:39:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngAkV-0008r9-MP for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 21:39:55 +0200 Original-Received: from localhost ([::1]:58274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngAkU-0001Ai-OA for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 15:39:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAJu-0002G9-Iq for emacs-devel@gnu.org; Sun, 17 Apr 2022 15:12:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAJs-0008WA-Ui; Sun, 17 Apr 2022 15:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ihzrTC+k/3NoA7PkpqYNwj6PrjVcoPQ2eYcBLwPvcek=; b=FFgstRwFmZ3/ +EbFgMVQlzrMXfz8DP+OguA9ySz8R8jFqbPrSpseX6m7ys823H6gvWRksW/N1VgdT8AbnTMCMMeYe OTCIM95EeJ1PhaaaI3PnmicNPaqAo+bMkw/z7dicNYMmZerzcHRGgBt28YIV4Y60D/5EJK52lrlhU /XsNMALzXhmWwQhoDipxN45mVXkY1U9nJrQHTFRAR5hAmQVzPrXrc86uiBK+z6ZJ4Ntiw1N5btOum z3qa/cPrySV7OhXjwMEOukMTNUj1RwKQPZYSd2ch/6DnCpcO5HJvC/pMS6t8iXHtOjzAQpg2nMNOX 44xZ3OBbVwikzPvO4PenOg==; Original-Received: from [87.69.77.57] (port=2103 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngAJs-00079u-Dm; Sun, 17 Apr 2022 15:12:24 -0400 In-Reply-To: (message from Paul Eggert on Sun, 17 Apr 2022 10:49:31 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288570 Archived-At: > Date: Sun, 17 Apr 2022 10:49:31 -0700 > From: Paul Eggert > Cc: Keith David Bershatsky , Emacs Devel > Instead of using Gnulib openat, I installed the attached patch into the > emacs-28 branch so that Emacs uses openat only on platforms like GNU > that define O_PATH (as these are the only platforms where Emacs passes a > value other than AT_FDCWD to openat's first argument). I tested this in > an artificial Fedora environment where I removed O_PATH, and it passed > 'make check', so this should port to OS X 10.9 as well. Please give it a > try. I reverted it. This kind of change on a stable branch, and for the benefit of an old macOS version on top of that, is unimaginable. We use 'open' and 'openat' in many places, and this change affects all of them. Please don't make any such changes without discussing them first. > PS. Could we somehow arrange for port-to-old-macOS testing to be done > before an Emacs release, rather than after? Hear, hear! If the pretest period is not used to test on some platform, users of that platform will have to live with unresolved bugs.