From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Wed, 31 Aug 2022 15:36:02 +0300 Message-ID: <83wnaosi8d.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <83zgfksllp.fsf@gnu.org> <3716f90c-3699-4ed7-03c8-f680dc8b206d@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, ams@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 14:37:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTMyR-0003jo-VJ for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 14:37:40 +0200 Original-Received: from localhost ([::1]:45442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTMyQ-00055s-W7 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 08:37:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMwc-0003bh-T3 for emacs-devel@gnu.org; Wed, 31 Aug 2022 08:35:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMwc-0006c2-CU; Wed, 31 Aug 2022 08:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wHpWJ1EP8b/sImX1UpfpTsdrEQM9jIaqZm4n3PaJi0U=; b=gbu+XwliHkMs PJUAIobZF9E2LjhDzaINd+GyvJAfqQG/Ue7IgJc/Xm7vsNU750utRB6uD0OqZzR8DbjxEY8sFEDNd 1X3RHbbdk99iS55mTpA9T6+RTFmMbb3DIjf9jad7zVamK9NSJ4zTgZszPqX6YwMtWX8x2qmpnYmdR J4I4+iRHJIutTb8wFQHkPIAMnojMc0bY/TyDIe6UlRh4U5jKY9HRH5C2BskJGKlHs/RBf065kJWPC wy0VzjYeydwttHRlBCk+3/x3XTrmK1OKgdBSUXzWPCQPK6Rsd8Vc4TyrzXqyAgLBHDnK/rnuLXet6 GthsHFF9LKcRZYjoBSqImQ==; Original-Received: from [87.69.77.57] (port=3142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMwS-0006vh-UK; Wed, 31 Aug 2022 08:35:39 -0400 In-Reply-To: <3716f90c-3699-4ed7-03c8-f680dc8b206d@yandex.ru> (message from Dmitry Gutov on Wed, 31 Aug 2022 14:57:38 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294427 Archived-At: > Date: Wed, 31 Aug 2022 14:57:38 +0300 > Cc: luangruo@yahoo.com, ams@gnu.org, larsi@gnus.org, juri@jurta.org, > emacs-devel@gnu.org > From: Dmitry Gutov > > >> + (dolist (f files) > >> + (copy-file (expand-file-name f root) > >> + (expand-file-name f tmpdir))) > > > > What if f includes leading directories, as in "lisp/foo.el"? If > > tmpdir doesn't have a subdirectory 'lisp', the copy-file will fail, > > no? > > That's unfortunate. I think you need to precede the copy-file call by (make-directory (file-name-directory (expand-file-name f tmpdir)) t)