From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful
Date: Wed, 12 Oct 2022 17:05:15 +0300 [thread overview]
Message-ID: <83wn95b0is.fsf@gnu.org> (raw)
In-Reply-To: <3ca55cea-712b-2e89-cdac-3a1893e3c53e@yandex.ru> (message from Dmitry Gutov on Wed, 12 Oct 2022 16:47:15 +0300)
> Date: Wed, 12 Oct 2022 16:47:15 +0300
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 12.10.2022 08:17, Eli Zaretskii wrote:
> >> Let's drop the "global" adjective, though: whether the command works
> >> "globally", "locally", or etc, depends on how the user made the search.
> > The "global" part is important, though: it's supposed to hint on why
> > find-definition results cannot be used. The opposite of "global" here
> > is "partial", not "local". If you can suggest a better word for
> > "global" here, please do.
>
> I think you're trying hard to make it clearer, but it still won't have
> 100% the intended effect.
>
> And it makes the error more likely to confuse the user and make them
> misunderstand how things work:
>
> 1) Saying "Cannot perform global replacement in find-definition
> results", with the explicit qualifier "global", potentially implies that
> a "local" replacement in find-definition results can be done. But it
> cannot. We can't do either currently for technical reasons.
>
> We don't want to do "local" replacements in find-definition results also
> for logical reasons, but that's just the reason why we're not in a hurry
> to remove the technical limitation.
>
> 2) The message implies 'r' is limited to "global" replacement. But it
> can easily do "partial" replacement, as long as the command that
> produces the list returns "match xrefs". dired-do-find-regexp, for
> example. Or project-find-regexp, when called with C-u, and the user
> specifies a specific directory. They will return a "partial" list of
> matches, compared to the full project search.
Sorry, I'm unconvinced. AFAICT, you are reiterating issues and
arguments we already have been through.
next prev parent reply other threads:[~2022-10-12 14:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m28rm2oiiy.fsf@Mini.fritz.box>
[not found] ` <83h70qhez0.fsf@gnu.org>
[not found] ` <m28rm2u0ga.fsf@Mini.fritz.box>
[not found] ` <83edvuhaby.fsf@gnu.org>
[not found] ` <m2zgeisg1u.fsf@Mini.fritz.box>
[not found] ` <831qruh67o.fsf@gnu.org>
[not found] ` <m2o7uysdfl.fsf@Mini.fritz.box>
[not found] ` <83y1u2foli.fsf@gnu.org>
[not found] ` <jwvh70q9whx.fsf-monnier+emacs@gnu.org>
[not found] ` <m235cas1w2.fsf@Mini.fritz.box>
[not found] ` <m2y1u2qm9s.fsf@Mini.fritz.box>
[not found] ` <jwvfsg996o3.fsf-monnier+emacs@gnu.org>
[not found] ` <m2o7uxqvlx.fsf@Mini.fritz.box>
[not found] ` <83zgehe6iq.fsf@gnu.org>
[not found] ` <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru>
[not found] ` <834jwfmn5a.fsf@gnu.org>
[not found] ` <f3967957-a4b2-8a9b-ae9c-b18b59370541@yandex.ru>
[not found] ` <838rlohzeo.fsf@gnu.org>
[not found] ` <d07f076f-21bf-9ab5-5ebe-1bf3d9fb7df1@yandex.ru>
[not found] ` <83mta2g91p.fsf@gnu.org>
2022-10-11 11:36 ` xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Dmitry Gutov
2022-10-11 11:51 ` Eli Zaretskii
2022-10-11 12:10 ` Dmitry Gutov
2022-10-11 12:17 ` Eli Zaretskii
2022-10-11 12:44 ` Dmitry Gutov
2022-10-11 12:55 ` Eli Zaretskii
2022-10-11 14:55 ` Dmitry Gutov
2022-10-11 16:01 ` Eli Zaretskii
2022-10-11 16:41 ` Dmitry Gutov
2022-10-11 16:50 ` Eli Zaretskii
2022-10-11 20:31 ` Dmitry Gutov
2022-10-12 5:17 ` Eli Zaretskii
2022-10-12 10:06 ` John Yates
2022-10-12 10:17 ` Eli Zaretskii
[not found] ` <CAJnXXogKsM=gMTFi2NivDMHW4A3EBtBtsNDBV3o5vcu2xXfuvw@mail.gmail.com>
2022-10-12 13:21 ` Eli Zaretskii
2022-10-12 16:12 ` John Yates
2022-10-12 13:47 ` Dmitry Gutov
2022-10-12 14:05 ` Eli Zaretskii [this message]
2022-10-11 14:04 ` Stefan Monnier
2022-10-11 14:07 ` Stefan Monnier
2022-10-11 15:07 ` Dmitry Gutov
2022-10-11 15:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn95b0is.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).