From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Status update of tree-sitter features Date: Fri, 30 Dec 2022 17:37:06 +0200 Message-ID: <83wn686gyl.fsf@gnu.org> References: <5d53b299-14e1-6f8b-58b3-7e16842d87a9@yandex.ru> <82501cb9-f51c-da5d-9f10-247d99012cb1@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13427"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, casouri@gmail.com, dgutov@yandex.ru, emacs-devel@gnu.org To: jostein@kjonigsen.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 30 16:37:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBHRn-0003HR-2u for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Dec 2022 16:37:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBHRW-0007PI-M7; Fri, 30 Dec 2022 10:37:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHRU-0007Ou-Rx for emacs-devel@gnu.org; Fri, 30 Dec 2022 10:37:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHRU-0000Pj-4F; Fri, 30 Dec 2022 10:37:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=h1Blmy15F6AvACLyswgVkdEV01piSmFA7FFbGAr/49Q=; b=aBjEnORUFbuNCvSjfOWj /8HRTnvFcn9exFW8CTFiJ6zd2e1iXtmrzllJRZJoXTvso/6rJmRLPE2xDMSelMTTdy9F3NIWQn/kg +LghghUfGpAvm74oZxeqBeS2DIXf8QIw9nVYpmc0MgcYHUIjpijGbKixsOWacpr+jCpiPT+5YK4jv PBARpAhGM/UYHh2BxQn9+P/EFFLLcl3zwo0+ECJ41tHS6a1qzcpfJh0JMom75xlaWVQKRctxmAHe0 BHYWJ9yQYCiax6YVF097ZqaHKA9dlXByBrpkSHl3YZDG+ior9MyG5T31Ejk3T7kk1jOi4VEKXl8Bp uNLb7k0qXUpGYw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHRT-0005ps-Ky; Fri, 30 Dec 2022 10:37:07 -0500 In-Reply-To: <82501cb9-f51c-da5d-9f10-247d99012cb1@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Fri, 30 Dec 2022 15:27:16 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302117 Archived-At: > Date: Fri, 30 Dec 2022 15:27:16 +0100 > Cc: Dmitry Gutov , emacs-devel > From: Jostein Kjønigsen > > I know that some people prefer "sparse" syntax-highlighting, while > others prefer more "complete" highlighting. Personally, I value being > able to see function invocations, and love how tree-sitter makes that > easy to highlight. > > As long as we have ways to accommodate both needs ("fruit salad" vs more > sparse fontification) I'm going to be happy, and we kind of already have > that through font-lock levels in the modes already. > > That said, some of the tree-sitter based major modes (half? most?) > currently highlight function-invocations on level 3. If we are to make > everyone happy, we need to make changes to that, and move that to 4. > > Which leads me to my main point here. > > Emacs 29 release is near. We should seriously limit the amount of > changes we apply in order to fix the things we need. > > Deciding at this point to rework all the features, which features we > should have, how they can be enabled/disabled, and what > enabling/disabling those should entail in practice... That's essentially > suggestion we rewrite all those tree-sitter-based major-modes. > > I think a much more realistic strategy at this point is: > > - to aim for what concrete things should be fontified at level 3 and 4 > (default vs max). We already know 1 thing we want to change here. > > - ensure the major-modes adhere to this with a minimum of changes in the > existing code. > > - and most importantly: leave the discussion about adding the ability > for users to enable/disable specific features, and how that should work > in practice (overlap, presedence, etc) for Emacs 30. I agree. Please post concrete proposals for making modes consistent regarding the default fontification level.