From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: file-equal-p Date: Thu, 16 Feb 2023 14:42:49 +0200 Message-ID: <83wn4h3ho6.fsf@gnu.org> References: <87a61es8fh.fsf.ref@yahoo.com> <87a61es8fh.fsf@yahoo.com> <83fsb681me.fsf@gnu.org> <87pmaaq9ua.fsf@yahoo.com> <838rgy7ztf.fsf@gnu.org> <874jrmq6bw.fsf@yahoo.com> <83357596a0.fsf@gnu.org> <87pma9pz5v.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18342"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 13:43:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSdbo-0004cB-O9 for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 13:43:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSdbE-0003fp-Ky; Thu, 16 Feb 2023 07:42:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSdbD-0003fg-Dd for emacs-devel@gnu.org; Thu, 16 Feb 2023 07:42:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSdbB-0007AZ-Dk; Thu, 16 Feb 2023 07:42:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U7iQTyLgG9MXMaafwhTZrYp3N0frYml9kjw1MFnxGNI=; b=owlXrYjrLoSh iQzYEYYkQfiniYjGYb9MN4gyHzP2fGukObgBP/tRAxKHp7J8wv9tvP3DrNT0DqJ7MxRRjwr9zbFV5 H4+jJLAL4oEwdgXAgurGy5JR7GrqKdvTiySkkvUQv/mlZlXQZVWrLXk6L9YKY1NMWO7hlr/R4SWUt lJGy2eQDTJB7hDvxJQmCEPRyxASobx8A8h+NPOOcfNXf+BxBblEYLV74Iyt6r0xPOrUPKwAsFKHIf rro4LMa7bwA45/MlBS++Cc+tlvkP4sJrOJH2iMXKtD5O3qODxBQgljWL0tm463fSsVhXVAFNsbmlm pOKJBkpTlZfMIxzrzttxAw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSdbA-0007PQ-KP; Thu, 16 Feb 2023 07:42:53 -0500 In-Reply-To: <87pma9pz5v.fsf@yahoo.com> (message from Po Lu on Thu, 16 Feb 2023 20:34:04 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303411 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 16 Feb 2023 20:34:04 +0800 > > Eli Zaretskii writes: > > > It is still one more test, done for everyone. > > Is file-equal-p a function called in particularly tight loops? I don't know, but punishing everyone for the benefit of a single OS sounds wrong to me. > It will otherwise result in file-attributes being called two more times > on the system being tested against. Not if you call file-attributes once and store the results in local variables.