From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Sun, 16 Apr 2023 08:43:31 +0300 Message-ID: <83wn2cbcvw.fsf@gnu.org> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> <5adfbf6f-fbcb-f4e8-3662-48bd5eb6a269@gmail.com> <9c8826af-a160-d36f-7577-2bc5ec0c2004@gmail.com> <265ac2c8-98bf-97db-2567-fce5db06577a@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 16 07:44:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnvBh-00086B-Kx for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Apr 2023 07:44:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnvAj-0008Qp-8g; Sun, 16 Apr 2023 01:43:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnvAh-0008Qb-P7 for emacs-devel@gnu.org; Sun, 16 Apr 2023 01:43:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnvAg-0003TE-6c; Sun, 16 Apr 2023 01:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NaZJ6EI6szEmeC07gnfIdJ/0vaqj6DupCv1EFOsWKR0=; b=QF7pntnjjSyj lrdDo5dvMyZomjC5zKDdUrFcWoPJPVO2Cmy1uKK/sD8bALsP9MMNUvZQ7WB97TnC8Sk1dFDkUiE3g zGDa6lNPoy3dA4OeoqlhBB7NTMu540pbNIEnBTuCK3PBitLEXs19H15HKyNHKBlWEX9rE3e9LL992 dMbDu6D63u/OjPKRsh/s85R57HRuV3QHicAVLnjZoicvnfRQqw8MJW3CwF61qrvY+hruA0HOgguce hIUgXGNFYioseuwqYDD6fI/RmM9ThiGVwic+RC+yfU1Pj5bfyNuVln4UZA4IJMjW8dN+ScnkBsEDc 1Bz5vptt/TDib2liaPCQkA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnvAf-0006IZ-8q; Sun, 16 Apr 2023 01:43:29 -0400 In-Reply-To: <265ac2c8-98bf-97db-2567-fce5db06577a@gmail.com> (message from Jim Porter on Sat, 15 Apr 2023 14:23:02 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305336 Archived-At: > Date: Sat, 15 Apr 2023 14:23:02 -0700 > From: Jim Porter > Cc: acm@muc.de, emacs-devel@gnu.org > > Oh, and just to give an idea of how common incorrect commit messages > are, my hook says that out of the last 5000 commits, 866 have a problem, > excluding the Eglot commits. > > If I also ignore lines starting with "*" that have no "/" in them (these > are almost always due to an unnecessary leading "*" on the first line of > the commit), we get down to 196 bad commit messages, or 3.9% of commits. And that's _a_lot_, no matter how you count them. Which should give people here some idea why I raised this issue in the first place: I needed to fix all those cases by hand while working on the pretest tarball.