From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make ispell localwords safe local variable Date: Sat, 26 Aug 2023 11:10:59 +0300 Message-ID: <83wmxikyuk.fsf@gnu.org> References: <87zg2s97x0.fsf@breatheoutbreathe.in> <83o7j8a59k.fsf@gnu.org> <87h6ozdalc.fsf@breatheoutbreathe.in> <83jztv89gi.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16466"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 26 10:11:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZoO3-00048l-En for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Aug 2023 10:11:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZoNN-0000SI-DZ; Sat, 26 Aug 2023 04:10:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZoNL-0000Rn-Af for emacs-devel@gnu.org; Sat, 26 Aug 2023 04:10:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZoNK-0006HH-OO; Sat, 26 Aug 2023 04:10:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DxJbaxUhiMkl6t0bxs9bO5tSVXSlUCZcYTFvtg8qGsE=; b=lRwpUdfdNaUB X8A4/7VXwldlFZXsVKX3DK1nijGJdTEumi5h92UalUtkLQlgf9YEETRJ2qQPgvFtVoiKd0ZoBIV4/ tuaQcGEKjdX/8FuINYmM96TZlGXeYTMks2PQ75Sm9la5F/bvUjQoErNDuHNzGNuA0ukvb6rLiE3FQ gP5NXo1OeL7EbAJgPvdIlpFW0sJ22O2xV8MwOWNI5bXXNQ1k6rhtRpd4QSBNtrFvMY9PZIfOvqsiW FOkiRQaE27PKDCBT7/YNkmWcG3LkmA/AmHoy74H6Xqej8I2hSAZi3aki9gI62qUmdQ4JjsvSrpje0 zDxY/TU7YLaWOjBRCdNZww==; In-Reply-To: (message from Joseph Turner on Wed, 16 Aug 2023 16:04:48 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309237 Archived-At: > Date: Wed, 16 Aug 2023 16:04:48 -0700 > From: Joseph Turner > CC: emacs-devel@gnu.org > > > > On August 16, 2023 10:12:30 AM PDT, Jim Porter wrote: > >On 8/16/2023 5:20 AM, Eli Zaretskii wrote: > >>> From: Joseph Turner > >>> Cc: emacs-devel@gnu.org > >>> Date: Tue, 15 Aug 2023 18:41:18 -0700 > >>> > >>> I am not sure. Unless someone can be certain that ispell can safely > >>> handle arbitrary strings, I think it's prudent to discard this patch. > >> > >> Does anyone else have an opinion about this? > > > >I'm not very familiar with how Emacs talks to ispell, but would the proposed change here be any less safe than the buffer-local "LocalWords" block? > > (which are sent to ispell without user confirmation) It sounds like no one sees a problem with this change, so I've now installed it on the master branch. Thanks.