From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: File watch support in autorevert.el Date: Sat, 12 Jan 2013 16:03:50 +0200 Message-ID: <83vcb2sdkp.fsf@gnu.org> References: <878v819kok.fsf@gmx.de> <83fw28uj9c.fsf@gnu.org> <87mwwfmij0.fsf@gmx.de> <837gnitz6o.fsf@gnu.org> <87d2xatup1.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1357999418 28206 80.91.229.3 (12 Jan 2013 14:03:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2013 14:03:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 12 15:03:56 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tu1gh-0000zO-Lm for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2013 15:03:55 +0100 Original-Received: from localhost ([::1]:50763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu1gR-00086K-6R for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2013 09:03:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu1gM-000862-EM for emacs-devel@gnu.org; Sat, 12 Jan 2013 09:03:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tu1gG-0002zJ-O1 for emacs-devel@gnu.org; Sat, 12 Jan 2013 09:03:34 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:60946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu1gG-0002z6-Fg for emacs-devel@gnu.org; Sat, 12 Jan 2013 09:03:28 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MGI00J00MV8MX00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sat, 12 Jan 2013 16:03:26 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MGI00JJEN1PM830@a-mtaout21.012.net.il>; Sat, 12 Jan 2013 16:03:26 +0200 (IST) In-reply-to: <87d2xatup1.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156278 Archived-At: > From: Michael Albinus > Cc: emacs-devel@gnu.org > Date: Sat, 12 Jan 2013 14:08:42 +0100 > > Eli Zaretskii writes: > > > I needed to make 2 changes to get this to work on Windows, see trunk > > revision 111499. Actually, I don't understand how it worked with > > inotify before my changes, since you were looking for 'modify' in the > > descriptor rather than in the action. Did I miss something? > > You're right, I've introduced a bug here at the very end of my tests > last night. > > > Btw, should we perhaps do something more sophisticated than > > string-equal to compare file names? On Windows, we probably should > > compare case-insensitively, but what about file-truename and friends > > on Posix platforms? > > What about `file-equal-p'? Can't use that on Windows, because FILE in the notification is just the basename. If we want to be able to do that, w32notify will have to prepend the directory that is being watched to the file names in the notifications.