From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: VCSWITNESS = fail ** 2 Date: Sun, 12 Jan 2014 20:53:43 +0200 Message-ID: <83vbxp6ngo.fsf@gnu.org> References: <20140112143733.B3F863811D4@snark.thyrsus.com> <83iotp88sb.fsf@gnu.org> <20140112164520.GA6770@thyrsus.com> <83d2jx85m3.fsf@gnu.org> <8361pp84as.fsf@gnu.org> <20140112184523.GC16457@thyrsus.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1389552847 26359 80.91.229.3 (12 Jan 2014 18:54:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jan 2014 18:54:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 12 19:54:13 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W2QAl-0000Ib-Dh for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 19:54:11 +0100 Original-Received: from localhost ([::1]:39049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2QAl-00024s-4f for ged-emacs-devel@m.gmane.org; Sun, 12 Jan 2014 13:54:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2QAe-00024g-UR for emacs-devel@gnu.org; Sun, 12 Jan 2014 13:54:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2QAZ-0002Pe-Gt for emacs-devel@gnu.org; Sun, 12 Jan 2014 13:54:04 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:48551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2QAZ-0002PW-8m for emacs-devel@gnu.org; Sun, 12 Jan 2014 13:53:59 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MZA00M00XQHO000@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sun, 12 Jan 2014 20:53:57 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZA00MJBXTXIJ90@a-mtaout23.012.net.il>; Sun, 12 Jan 2014 20:53:57 +0200 (IST) In-reply-to: <20140112184523.GC16457@thyrsus.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168216 Archived-At: > Date: Sun, 12 Jan 2014 13:45:23 -0500 > From: "Eric S. Raymond" > Cc: emacs-devel@gnu.org > > So I reverted to the trunk version and instrumented, by inserting an > echo before the generated make command. Lo and behold, vcswitness was > empty. Is it still empty for you with the current trunk? (It is not empty for me.) If so, do you have a .bzr/checkout/dirstate file under the top-level directory of your bzr branch? Also, did you try that in the bzr branch, or in the directory where you build (assuming that they are different, i.e. that you don't build in-place)? > Those three lines are, by demonstration, so prone to be misread that they > tripped up Eli and me in two different ways and I still have no theory > to account for why they were different. > > That says "maintainence nightmare - should be scrapped and replaced" > to me. Maybe so, but replaced with what? The main requirement for this trick is that the value of VCSWITNESS is computed in the top-level Makefile, but used in a sub-Make. So the variables that should be expanded by the sub-Make should be quoted, while those that need to be expanded by the top-level Make should not be quoted. Is there a better way of expressing that than what we have now?