unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: esr@thyrsus.com
Cc: emacs-devel@gnu.org
Subject: Re: VCSWITNESS = fail ** 2
Date: Sun, 12 Jan 2014 20:53:43 +0200	[thread overview]
Message-ID: <83vbxp6ngo.fsf@gnu.org> (raw)
In-Reply-To: <20140112184523.GC16457@thyrsus.com>

> Date: Sun, 12 Jan 2014 13:45:23 -0500
> From: "Eric S. Raymond" <esr@thyrsus.com>
> Cc: emacs-devel@gnu.org
> 
> So I reverted to the trunk version and instrumented, by inserting an
> echo before the generated make command.  Lo and behold, vcswitness was
> empty.

Is it still empty for you with the current trunk?  (It is not empty
for me.)  If so, do you have a .bzr/checkout/dirstate file under the
top-level directory of your bzr branch?  Also, did you try that in the
bzr branch, or in the directory where you build (assuming that they
are different, i.e. that you don't build in-place)?

> Those three lines are, by demonstration, so prone to be misread that they 
> tripped up Eli and me in two different ways and I still have no theory
> to account for why they were different.
> 
> That says "maintainence nightmare - should be scrapped and replaced"
> to me.

Maybe so, but replaced with what?

The main requirement for this trick is that the value of VCSWITNESS is
computed in the top-level Makefile, but used in a sub-Make.  So the
variables that should be expanded by the sub-Make should be quoted,
while those that need to be expanded by the top-level Make should not
be quoted.  Is there a better way of expressing that than what we have
now?



  reply	other threads:[~2014-01-12 18:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 14:37 VCSWITNESS = fail ** 2 Eric S. Raymond
2014-01-12 15:02 ` Lars Magne Ingebrigtsen
2014-01-12 15:17   ` Eric S. Raymond
2014-01-12 17:28     ` Eli Zaretskii
2014-01-12 16:27 ` Eli Zaretskii
2014-01-12 16:45   ` Eric S. Raymond
2014-01-12 17:36     ` Eli Zaretskii
2014-01-12 18:04       ` Eli Zaretskii
2014-01-12 18:45         ` Eric S. Raymond
2014-01-12 18:53           ` Eli Zaretskii [this message]
2014-01-12 19:10             ` Glenn Morris
2014-01-12 21:00               ` Eli Zaretskii
2014-01-13  2:31                 ` Glenn Morris
2014-01-12 19:25           ` David Kastrup
2014-01-12 19:42             ` Eric S. Raymond
2014-01-12 20:02               ` David Kastrup
2014-01-12 21:04               ` Eli Zaretskii
2014-01-13 15:41   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vbxp6ngo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=esr@thyrsus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).