From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Showing the relevant part of a diff Date: Fri, 19 Feb 2016 10:47:04 +0200 Message-ID: <83vb5lrss7.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1455871644 29180 80.91.229.3 (19 Feb 2016 08:47:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2016 08:47:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Herring\, Davis" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 09:47:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWgic-0000Zd-Os for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 09:47:18 +0100 Original-Received: from localhost ([::1]:49958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWgib-0006GG-V4 for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2016 03:47:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWgiY-0006G0-2w for emacs-devel@gnu.org; Fri, 19 Feb 2016 03:47:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWgiU-0004uQ-Sm for emacs-devel@gnu.org; Fri, 19 Feb 2016 03:47:14 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWgiU-0004uK-PO; Fri, 19 Feb 2016 03:47:10 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2695 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWgiT-0003NC-Hw; Fri, 19 Feb 2016 03:47:10 -0500 In-reply-to: (herring@lanl.gov) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200188 Archived-At: > From: "Herring, Davis" > Date: Fri, 19 Feb 2016 05:43:23 +0000 > +(defun diff-goto-line (file line column) > + "Go to the place in this diff producing LINE in FILE. This first line should mention COLUMN as well. > +If LINE (in the new version of FILE) is included, move to it and then ^^^^^^^^^^^ Included where? > +COLUMN characters forward. If it is absent, go to the first hunk > +starting after LINE, or to the end if none does. Why this fallback? Would it make sense to just stay at the beginning? > + (unless rev2 ; remember the position in the or a current buffer Typo in the comment. Thanks.