From: Eli Zaretskii <eliz@gnu.org>
To: "Herring\, Davis" <herring@lanl.gov>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Showing the relevant part of a diff
Date: Fri, 19 Feb 2016 10:47:04 +0200 [thread overview]
Message-ID: <83vb5lrss7.fsf@gnu.org> (raw)
In-Reply-To: <B393F5AD12955C48A84FFB08032CD04F6C432C3C@ECS-EXG-P-MB01.win.lanl.gov> (herring@lanl.gov)
> From: "Herring, Davis" <herring@lanl.gov>
> Date: Fri, 19 Feb 2016 05:43:23 +0000
> +(defun diff-goto-line (file line column)
> + "Go to the place in this diff producing LINE in FILE.
This first line should mention COLUMN as well.
> +If LINE (in the new version of FILE) is included, move to it and then
^^^^^^^^^^^
Included where?
> +COLUMN characters forward. If it is absent, go to the first hunk
> +starting after LINE, or to the end if none does.
Why this fallback? Would it make sense to just stay at the beginning?
> + (unless rev2 ; remember the position in the or a current buffer
Typo in the comment.
Thanks.
next prev parent reply other threads:[~2016-02-19 8:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 5:43 [PATCH] Showing the relevant part of a diff Herring, Davis
2016-02-19 5:49 ` Lars Ingebrigtsen
2016-02-19 8:47 ` Eli Zaretskii [this message]
2016-02-20 20:20 ` Herring, Davis
2016-02-20 20:39 ` Eli Zaretskii
2016-02-20 22:49 ` Herring, Davis
2016-07-15 21:19 ` Davis Herring
2016-07-16 2:14 ` Herring, Davis
2016-07-16 9:28 ` Dmitry Gutov
2016-07-18 14:15 ` Ted Zlatanov
2016-07-18 23:20 ` Dmitry Gutov
2016-07-19 14:12 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vb5lrss7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=herring@lanl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).