From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Thu, 08 Sep 2016 05:47:41 +0300 Message-ID: <83vay785v6.fsf@gnu.org> References: <20160907153014.15752-1-toke@toke.dk> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1473302909 15812 195.159.176.226 (8 Sep 2016 02:48:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2016 02:48:29 +0000 (UTC) Cc: toke@toke.dk, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 04:48:21 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhpNx-0002o1-E6 for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 04:48:17 +0200 Original-Received: from localhost ([::1]:44537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhpNv-0000YT-Bi for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2016 22:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhpNg-0000VV-GV for emacs-devel@gnu.org; Wed, 07 Sep 2016 22:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhpNa-00041G-Fa for emacs-devel@gnu.org; Wed, 07 Sep 2016 22:47:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhpNa-000415-Ck; Wed, 07 Sep 2016 22:47:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2848 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bhpNZ-0002kp-5N; Wed, 07 Sep 2016 22:47:53 -0400 In-reply-to: (message from Lars Ingebrigtsen on Wed, 07 Sep 2016 21:14:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207285 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 07 Sep 2016 21:14:10 +0200 > Cc: emacs-devel@gnu.org > > I think that test should be removed so that Emacs 25.1 can be released > (with the same level of workingness that that function has in Emacs > 24.4). That makes very little sense to me, as it will re-introduce the problems which caused us to add the test. And it's a code change, so it will require at least the same amount of testing that whatever fix we come up with for this use case. Sounds like lose-lose to me.