From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Lisp-friendly backtraces [was: Lispy backtraces]
Date: Tue, 06 Dec 2016 20:55:36 +0200 [thread overview]
Message-ID: <83vauwj39z.fsf@gnu.org> (raw)
In-Reply-To: <e5454226-ba53-8d9b-481d-974916427a8b@gmail.com> (message from Clément Pit--Claudel on Mon, 5 Dec 2016 13:59:03 -0500)
> Cc: emacs-devel@gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Mon, 5 Dec 2016 13:59:03 -0500
>
> Done and done :) See attached patch.
Thanks.
> +@defun mapbacktrace function &optional base
> +The function @code{mapbacktrace} calls @var{function} once for each
> +frame in the backtrace, starting at the first frame whose
> +@var{function} is base (or from the top if @var{base} is omitted or
^^^^^^^^^^^^^^^^^^^^^^
Here, "function" should not have the @var markup, and "base" should.
> +the only supported property is @code{:debug-on-exit}, which is t if
^
@code{t}
> +the frame's debug-on-exit flag is set.
^^^^^^^^^^^^^
@code{debug-on-exit}
Also, suggest to say "stack frame's", to avoid confusion with the
frames on display.
> +(defun backtrace-frames (&optional base)
> + "Collect all frames of current backtrace into a list.
> +If non-nil BASE should be a function, and frames before its
^
Comma here.
> +(defun backtrace-frame (nframes &optional base)
> + "Return the function and arguments NFRAMES up from current execution point.
> +If non-nil BASE should be a function, and NFRAMES counts from its
^
Likewise.
> + if (backtrace_debug_on_exit (pdl))
> + flags = Fcons (QCdebug_on_exit, Fcons (Qt, Qnil));
^^^^
Too many blanks here. Should be only 2.
Otherwise, LGTM.
Thanks for doing this!
next prev parent reply other threads:[~2016-12-06 18:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160922231447.GA3833@odonien.localdomain>
[not found] ` <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com>
[not found] ` <20160923075116.GA612@odonien.localdomain>
[not found] ` <82e39377-f31b-698c-5a9a-343868686799@gmail.com>
[not found] ` <20161202005226.GA4215@odonien.localdomain>
2016-12-02 1:23 ` bug#24514: 24.5; Lispy backtraces Clément Pit--Claudel
2016-12-02 2:24 ` Stefan Monnier
2016-12-03 22:15 ` Clément Pit--Claudel
2016-12-04 15:30 ` Eli Zaretskii
2016-12-04 19:27 ` Clément Pit--Claudel
2016-12-04 20:41 ` Eli Zaretskii
2016-12-04 22:14 ` Clément Pit--Claudel
2016-12-05 3:30 ` Eli Zaretskii
2016-12-05 6:02 ` Lisp-friendly backtraces [was: Lispy backtraces] Clément Pit--Claudel
2016-12-05 13:20 ` Stefan Monnier
2016-12-05 14:14 ` Clément Pit--Claudel
2016-12-05 14:37 ` Stefan Monnier
2016-12-05 16:31 ` Clément Pit--Claudel
2016-12-05 16:54 ` Eli Zaretskii
2016-12-05 16:23 ` Eli Zaretskii
2016-12-05 18:59 ` Clément Pit--Claudel
2016-12-06 18:55 ` Eli Zaretskii [this message]
2016-12-07 8:27 ` Clément Pit--Claudel
2016-12-12 22:42 ` Clément Pit--Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vauwj39z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).