From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs26, ucs-normalize.el, =?utf-8?Q?Symbol=E2=80=99s?= function definition is void: regexp-opt-charset Date: Thu, 14 Feb 2019 05:37:49 +0200 Message-ID: <83va1nnipe.fsf@gnu.org> References: <83a7j1llur.fsf@gnu.org> <44aa7320-5b14-04a7-7140-1fe2d930a04b@cs.ucla.edu> <69347b44-3ccd-bbcb-4589-d5e221ca2737@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95783"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rgm@gnu.org, silent2600@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 14 04:42:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gu7vI-000Oph-9L for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 04:42:52 +0100 Original-Received: from localhost ([127.0.0.1]:39298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu7vH-0004pS-Au for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2019 22:42:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu7qY-00011m-RW for emacs-devel@gnu.org; Wed, 13 Feb 2019 22:38:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu7qY-0003Mb-06; Wed, 13 Feb 2019 22:37:58 -0500 Original-Received: from [176.228.60.248] (port=3713 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gu7qX-0007Ae-G7; Wed, 13 Feb 2019 22:37:57 -0500 In-reply-to: <69347b44-3ccd-bbcb-4589-d5e221ca2737@cs.ucla.edu> (message from Paul Eggert on Wed, 13 Feb 2019 15:04:18 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233304 Archived-At: > Cc: Eli Zaretskii , silent2600@gmail.com, emacs-devel@gnu.org > From: Paul Eggert > Date: Wed, 13 Feb 2019 15:04:18 -0800 > > diff --git a/lisp/international/ucs-normalize.el b/lisp/international/ucs-normalize.el > index 9d55470d94..6f1e770c09 100644 > --- a/lisp/international/ucs-normalize.el > +++ b/lisp/international/ucs-normalize.el > @@ -109,7 +109,9 @@ > > (defconst ucs-normalize-version "1.2") > > -(eval-when-compile (require 'cl-lib)) > +(eval-when-compile > + (require 'cl-lib) > + (require 'regexp-opt)) I think it would be better to add the 'require' in the same eval-when-compile form which calls regexp-opt-charset.