unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: rgm@gnu.org, silent2600@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset
Date: Thu, 14 Feb 2019 05:37:49 +0200	[thread overview]
Message-ID: <83va1nnipe.fsf@gnu.org> (raw)
In-Reply-To: <69347b44-3ccd-bbcb-4589-d5e221ca2737@cs.ucla.edu> (message from Paul Eggert on Wed, 13 Feb 2019 15:04:18 -0800)

> Cc: Eli Zaretskii <eliz@gnu.org>, silent2600@gmail.com, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 13 Feb 2019 15:04:18 -0800
> 
> diff --git a/lisp/international/ucs-normalize.el b/lisp/international/ucs-normalize.el
> index 9d55470d94..6f1e770c09 100644
> --- a/lisp/international/ucs-normalize.el
> +++ b/lisp/international/ucs-normalize.el
> @@ -109,7 +109,9 @@
>  
>  (defconst ucs-normalize-version "1.2")
>  
> -(eval-when-compile (require 'cl-lib))
> +(eval-when-compile
> +  (require 'cl-lib)
> +  (require 'regexp-opt))

I think it would be better to add the 'require' in the same
eval-when-compile form which calls regexp-opt-charset.



  reply	other threads:[~2019-02-14  3:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11  1:21 emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset hx
2019-02-11 16:39 ` Eli Zaretskii
2019-02-12  0:16   ` hx
2019-02-11 23:39 ` Paul Eggert
2019-02-12  3:35   ` Eli Zaretskii
2019-02-13 18:49     ` Paul Eggert
2019-02-13 19:18       ` Eli Zaretskii
2019-02-13 20:04       ` Glenn Morris
2019-02-13 20:15         ` Stefan Monnier
2019-02-14  3:32           ` Eli Zaretskii
2019-02-14  4:21             ` Stefan Monnier
2019-02-13 23:04         ` Paul Eggert
2019-02-14  3:37           ` Eli Zaretskii [this message]
2019-02-14 18:48             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83va1nnipe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    --cc=silent2600@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).