unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Keeping replace-buffer-contents runtime in bounds
Date: Sun, 24 Feb 2019 18:12:19 +0200	[thread overview]
Message-ID: <83va19np24.fsf@gnu.org> (raw)
In-Reply-To: <87y365a42g.fsf@gnu.org> (message from Tassilo Horn on Sun, 24 Feb 2019 11:11:51 +0100)

> From: Tassilo Horn <tsdh@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Sun, 24 Feb 2019 11:11:51 +0100
> 
> > Thanks for working on this.  My only other comment is that maybe we
> > should allow passing the time-out value via the function's arguments,
> > not via a global variable.  It seems to me the time-out will be used
> > in more use cases than MAX-COSTS, and in any case treating these two
> > differently API-wise sounds strangely inconsistent.
> 
> I've done that and landed it in master.

Thanks!



  reply	other threads:[~2019-02-24 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 20:09 Keeping replace-buffer-contents runtime in bounds Tassilo Horn
2019-02-17 15:50 ` Eli Zaretskii
2019-02-17 18:26   ` Tassilo Horn
2019-02-17 18:59     ` Eli Zaretskii
2019-02-24 10:11   ` Tassilo Horn
2019-02-24 16:12     ` Eli Zaretskii [this message]
2019-02-24 20:13     ` Philipp Stephani
2019-02-25  6:28       ` Tassilo Horn
2019-02-25 20:16         ` Tassilo Horn
2019-02-25 21:03           ` Stefan Monnier
2019-02-26  6:51             ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83va19np24.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).