From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's
	overriden next line
Date: Sat, 16 Mar 2019 14:43:51 +0200
Message-ID: <83va0jxa48.fsf@gnu.org>
References: <20190316015314.2335-1-Hi-Angel@yandex.ru>
	<20190316015314.2335-2-Hi-Angel@yandex.ru>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="187326"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 13:47:18 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1h58ib-000mdW-Tk
	for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 13:47:18 +0100
Original-Received: from localhost ([127.0.0.1]:41574 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1h58ia-0003YL-Rh
	for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 08:47:16 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:38912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1h58hR-0003XA-Ea
	for emacs-devel@gnu.org; Sat, 16 Mar 2019 08:46:06 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59006)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1h58fV-0003Ok-QP; Sat, 16 Mar 2019 08:44:05 -0400
Original-Received: from [176.228.60.248] (port=1746 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1h58fV-0007cN-5h; Sat, 16 Mar 2019 08:44:05 -0400
In-reply-to: <20190316015314.2335-2-Hi-Angel@yandex.ru> (message from
	Konstantin Kharlamov on Sat, 16 Mar 2019 04:53:13 +0300)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:234210
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/234210>

> From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> Date: Sat, 16 Mar 2019 04:53:13 +0300
> 
> diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
> index 05dc7aa1baf..62637414ef8 100644
> --- a/lisp/progmodes/etags.el
> +++ b/lisp/progmodes/etags.el
> @@ -1395,11 +1395,6 @@ etags-goto-tag-location
>            (re-search-forward pat nil t)
>            (user-error "Rerun etags: `%s' not found in %s"
>                        pat buffer-file-name)))
> -    ;; Position point at the right place
> -    ;; if the search string matched an extra Ctrl-m at the beginning.
> -    (and (eq selective-display t)
> -	 (looking-at "\^m")
> -	 (forward-char 1))
>      (beginning-of-line)))

Did you actually try this change with selective-display in effect?
Because I'm not sure it is correct in that case.

Thanks.