From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Towards a cleaner build: feedmail
Date: Sat, 15 Jun 2019 18:30:54 +0300
Message-ID: <83v9x6vpap.fsf@gnu.org>
References: <m3r28xrfl9.fsf@gnus.org> <m3r282zfjx.fsf@gnus.org>
 <83a7eo9nsh.fsf@gnu.org> <m3k1dqzyul.fsf@gnus.org>
 <m336kezrno.fsf@gnus.org> <jwvzhmmsca1.fsf-monnier+emacs@gnu.org>
 <m3sgsel567.fsf@gnus.org> <m3k1dpk7y7.fsf@gnus.org>
 <m3ftodk7ps.fsf@gnus.org> <m3blz1ioxz.fsf_-_@gnus.org>
 <jwv36kdsbw8.fsf-monnier+emacs@gnu.org> <m3pnngmko2.fsf@gnus.org>
 <jwvr27wwa0b.fsf-monnier+emacs@gnu.org> <m3v9x8l0rq.fsf@gnus.org>
 <jwvftocvv3v.fsf-monnier+emacs@gnu.org> <m34l4rauem.fsf@gnus.org>
 <m3a7ej9c87.fsf_-_@gnus.org> <831rzvvsgp.fsf@gnu.org>
 <m3wohm9atz.fsf@gnus.org> <m3r27u9a3o.fsf@gnus.org>
 <83y322vqvg.fsf@gnu.org> <m3k1dm98c2.fsf_-_@gnus.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="82647"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Lars Ingebrigtsen <larsi@gnus.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 15 17:30:59 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hcAdv-000LK7-95
	for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 17:30:59 +0200
Original-Received: from localhost ([::1]:32794 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hcAdt-00069y-P6
	for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 11:30:57 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33367)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hcAdk-00069Z-My
 for emacs-devel@gnu.org; Sat, 15 Jun 2019 11:30:49 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38200)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hcAdk-0003eE-I5; Sat, 15 Jun 2019 11:30:48 -0400
Original-Received: from [176.228.60.248] (port=2385 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hcAdj-0005Xz-Oy; Sat, 15 Jun 2019 11:30:48 -0400
In-reply-to: <m3k1dm98c2.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on
 Sat, 15 Jun 2019 17:28:13 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:237693
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/237693>

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 15 Jun 2019 17:28:13 +0200
> 
> I think the fix is pretty trivial:
> 
> diff --git a/lisp/mail/feedmail.el b/lisp/mail/feedmail.el
> index 943bdd8851..6f50c3e4ed 100644
> --- a/lisp/mail/feedmail.el
> +++ b/lisp/mail/feedmail.el
> @@ -2170,7 +2170,7 @@ feedmail-queue-send-edit-prompt-inner
>  	  (if (= user-sez help-char)
>                ;; FIXME: This seems to want to refer to the `helper' argument,
>                ;; but it's quoted so the `helper' arg ends up unused!
> -	      (setq answer '(^ . helper))
> +	      (setq answer (cons '^ helper))
>  	    (if (or (eq user-sez ?\C-m) (eq user-sez ?\C-j) (eq user-sez ?y))
>  		(setq user-sez d-char))
>  	    ;; these char-to-int things are because of some
> 
> but it would be nice to have someone confirm that this analysis is right
> before doing anything.

I don't think you'll find someone to confirm: feedmail is probably
going to be moved to obsolete/.  So I suggest to push that change.