From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tab bar tabs landed on master Date: Wed, 09 Oct 2019 21:59:39 +0300 Message-ID: <83v9sxu4mc.fsf@gnu.org> References: <8736gci5jn.fsf@mail.linkov.net> <83muej8a0f.fsf@gnu.org> <87zhijqfys.fsf@mail.linkov.net> <834l0r84at.fsf@gnu.org> <87bluyj51u.fsf@mail.linkov.net> <838spz45zc.fsf@gnu.org> <87a7aex2v9.fsf@mail.linkov.net> <83k19h3it3.fsf@gnu.org> <87sgo4tlic.fsf@mail.linkov.net> <83blusz7ec.fsf@gnu.org> <83y2xuur76.fsf@gnu.org> <871rvliwtu.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144228"; mail-complaints-to="usenet@blaine.gmane.org" Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 22:52:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIIwU-000bNI-GB for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 22:52:18 +0200 Original-Received: from localhost ([::1]:57664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIIwS-0001dj-Q9 for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 16:52:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48901) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHCA-0000cS-0B for emacs-devel@gnu.org; Wed, 09 Oct 2019 15:00:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iIHC9-0006DB-HZ; Wed, 09 Oct 2019 15:00:21 -0400 Original-Received: from [176.228.60.248] (port=1636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iIHBt-0000Fa-7H; Wed, 09 Oct 2019 15:00:14 -0400 In-reply-to: <871rvliwtu.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 09 Oct 2019 21:43:25 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240794 Archived-At: > From: Juri Linkov > Cc: lekktu@gmail.com, emacs-devel@gnu.org > Date: Wed, 09 Oct 2019 21:43:25 +0300 > > > It is possible that we will need to force reset of up_modifier bit > > from the event modifiers inside tty_handle_tab_bar_click, I'm not > > sure. If you get error messages when clicking on the tab bar saying > > something like " is undefined", this is the > > reason. > > Today I tried your patch, and observe the following behavior - > typing on a tab displays in the each area: > > tab-bar up-current-tab- > > and waits for reading the next event. I think this is a sign that the up_modifier needs to be reset from the event modifiers inside tty_handle_tab_bar_click, as I envisioned. Can you try that?