From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: python: Let pdb tracking not kill buffers Date: Sat, 02 Nov 2019 19:29:09 +0200 Message-ID: <83v9s2i3ve.fsf@gnu.org> References: <83a7af66fo.fsf@gnu.org> <38E2A645-5581-4724-B87A-37933D1AE4A4@gmail.com> <34E1410D-90ED-412B-96BD-B6934F34C9FA@gmail.com> <83ftj8lz23.fsf@gnu.org> <6F09449A-0EDF-4D7C-86DC-EE466CE032C8@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40260"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Andrii Kolomoiets Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 02 18:30:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQxER-000AM3-AT for ged-emacs-devel@m.gmane.org; Sat, 02 Nov 2019 18:30:35 +0100 Original-Received: from localhost ([::1]:49508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQxEN-0007lz-N4 for ged-emacs-devel@m.gmane.org; Sat, 02 Nov 2019 13:30:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47710) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQxDD-0007jA-Al for emacs-devel@gnu.org; Sat, 02 Nov 2019 13:29:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQxDC-00086v-4Y; Sat, 02 Nov 2019 13:29:18 -0400 Original-Received: from [176.228.60.248] (port=2698 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQxD9-0007ug-Az; Sat, 02 Nov 2019 13:29:17 -0400 In-reply-to: <6F09449A-0EDF-4D7C-86DC-EE466CE032C8@gmail.com> (message from Andrii Kolomoiets on Sat, 2 Nov 2019 18:37:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241734 Archived-At: > From: Andrii Kolomoiets > Date: Sat, 2 Nov 2019 18:37:26 +0200 > Cc: emacs-devel@gnu.org > > On 1 Nov 2019, at 11:35, Eli Zaretskii wrote: > > Can you please add: > > > > . Commit log message formatted according to instructions in > > CONTRIBUTE > > . Suitable short entry for NEWS about the new options > > Please see attached updated patch. Thanks. > Current python-pdbtrack-stacktrace-info-regexp match only lines with real > filenames, like: > > /Users/mad/test.py(3)()->None > > Pdb command "next" can bring us to upper stack frame, like: > > (1)()->None OK, but the change in that variable should be called out in the log entry, so please add that, together with the explanation above. Maybe also add a comment before the variable to explain what it needs to match. > +*** New user option 'python-pdbtrack-kill-buffers'. > +If nil, buffers opened during pdbtracking session is not killed when ^^ "are", plural. Thanks.