unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master a283996: Add command for customizing current newsticker feed
@ 2021-02-23 17:35 Eli Zaretskii
  2021-02-23 18:38 ` Ulf Jasper
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-02-23 17:35 UTC (permalink / raw)
  To: Ulf Jasper; +Cc: emacs-devel

The new code installed by this change triggers a warning:

  In newsticker-customize-feed:
  net/newst-backend.el:656:46: Warning: reference to free variable `feed-name'

And this code looks strange to me:

  +(defun newsticker-customize-feed (feed-name)
  +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
  +  (interactive
  +   (list (completing-read "Name of feed or group to edit: "
  +                          (append (mapcar #'car newsticker-url-list)
  +                                  nil t feed-name))))

Look at the arguments of 'append': what is that supposed to do?

And how can the 'interactive' form reference the argument list that
it's supposed to generate?  What am I missing?

Thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread
[parent not found: <20210223164040.7990.38864@vcs0.savannah.gnu.org>]

end of thread, other threads:[~2021-02-23 18:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 17:35 master a283996: Add command for customizing current newsticker feed Eli Zaretskii
2021-02-23 18:38 ` Ulf Jasper
     [not found] <20210223164040.7990.38864@vcs0.savannah.gnu.org>
     [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org>
2021-02-23 17:05   ` Basil L. Contovounesios
2021-02-23 18:38     ` Ulf Jasper

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).