unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ulf Jasper <ulf.jasper@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: master a283996: Add command for customizing current newsticker feed
Date: Tue, 23 Feb 2021 19:35:58 +0200	[thread overview]
Message-ID: <83v9aiu1oh.fsf@gnu.org> (raw)

The new code installed by this change triggers a warning:

  In newsticker-customize-feed:
  net/newst-backend.el:656:46: Warning: reference to free variable `feed-name'

And this code looks strange to me:

  +(defun newsticker-customize-feed (feed-name)
  +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
  +  (interactive
  +   (list (completing-read "Name of feed or group to edit: "
  +                          (append (mapcar #'car newsticker-url-list)
  +                                  nil t feed-name))))

Look at the arguments of 'append': what is that supposed to do?

And how can the 'interactive' form reference the argument list that
it's supposed to generate?  What am I missing?

Thanks.



             reply	other threads:[~2021-02-23 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 17:35 Eli Zaretskii [this message]
2021-02-23 18:38 ` master a283996: Add command for customizing current newsticker feed Ulf Jasper
     [not found] <20210223164040.7990.38864@vcs0.savannah.gnu.org>
     [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org>
2021-02-23 17:05   ` Basil L. Contovounesios
2021-02-23 18:38     ` Ulf Jasper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9aiu1oh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ulf.jasper@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).