From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Revert recent buggy font-locking changes in python.el Date: Thu, 04 Mar 2021 16:12:25 +0200 Message-ID: <83v9a7hut2.fsf@gnu.org> References: <877dmnw3x1.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20571"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ddavis@ddavis.io, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 15:13:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHojc-0005FB-O9 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 15:13:48 +0100 Original-Received: from localhost ([::1]:50146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHojb-0000U3-Nw for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 09:13:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHoib-0007cZ-To for emacs-devel@gnu.org; Thu, 04 Mar 2021 09:12:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60247) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHoib-00082c-I3; Thu, 04 Mar 2021 09:12:45 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHoiY-00005G-RT; Thu, 04 Mar 2021 09:12:44 -0500 In-Reply-To: <877dmnw3x1.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 04 Mar 2021 12:31:54 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265955 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 04 Mar 2021 12:31:54 +0100 > Cc: emacs-devel@gnu.org > > Doug Davis writes: > > > (Bug#45679) and (Bug#46233) report buggy font-locking in python.el. I > > was able to trace it back to b2ce94fa5e - but I haven't been able to > > figure out _what_ the bug is (it's easy to trigger the issue, i.e. > > trigger the wonky font-locking), but not obvious how it's happening). > > > > Would it be reasonable to revert those changes (the attached patch does > > it)? I would also be happy to help solve the underlying issue (by > > testing new patches or being pointed to any tips for debugging font > > locking issues). > > The patch seemed to fix the issue in bug#45341, so it'd be better to try > to determine what it doesn't get right instead of reverting outright. I agree.