From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Unicode combining characters Date: Thu, 27 May 2021 16:44:24 +0300 Message-ID: <83v9748f5z.fsf@gnu.org> References: <83k0nmbubk.fsf@gnu.org> <83v975ac4s.fsf@gnu.org> <83lf81a04l.fsf@gnu.org> <83y2c08qg2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16885"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Anand Tamariya Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 27 15:48:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmGMo-0004Cg-54 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 May 2021 15:48:06 +0200 Original-Received: from localhost ([::1]:46610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGMn-0002Sr-15 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 May 2021 09:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGJL-0008Oi-SG for emacs-devel@gnu.org; Thu, 27 May 2021 09:44:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44342) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGJL-000695-Jq; Thu, 27 May 2021 09:44:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4772 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGJC-0003Or-HM; Thu, 27 May 2021 09:44:27 -0400 In-Reply-To: (message from Anand Tamariya on Thu, 27 May 2021 18:57:58 +0530) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269945 Archived-At: > From: Anand Tamariya > Date: Thu, 27 May 2021 18:57:58 +0530 > Cc: emacs-devel@gnu.org > > OK, I improved this case now on master, please take a look. > > Wonderful!! It works. Thanks. Thanks for testing. > Do you think (current-column) should also return a value conforming to the display logic? e.g. if 'ra' above is > the first character in the line and point next to it, should it report 1 or 2? That'd be too much, IMO. current-column is called in many places, and it would be unexpected for it to return different values depending on the font and the frame. The correspondence between these two functions is not 100% now anyway (e.g., current-column is sensitive to auto-composition-mode, whereas string-width isn't). Lisp programs that need 100% accuracy in these matters should call window-text-pixel-size.