unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Unicode combining characters
Date: Thu, 27 May 2021 16:44:24 +0300	[thread overview]
Message-ID: <83v9748f5z.fsf@gnu.org> (raw)
In-Reply-To: <CADm7Y4mW5DgynnQXC5c6qfgAGvo2y=CnnuNHmaiOZ87tG4i_Cw@mail.gmail.com> (message from Anand Tamariya on Thu, 27 May 2021 18:57:58 +0530)

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Thu, 27 May 2021 18:57:58 +0530
> Cc: emacs-devel@gnu.org
> 
>  OK, I improved this case now on master, please take a look.
> 
> Wonderful!! It works. Thanks.

Thanks for testing.

> Do you think (current-column) should also return a value conforming to the display logic? e.g. if 'ra' above is
> the first character in the line and point next to it, should it report 1 or 2?

That'd be too much, IMO.  current-column is called in many places, and
it would be unexpected for it to return different values depending on
the font and the frame.  The correspondence between these two
functions is not 100% now anyway (e.g., current-column is sensitive to
auto-composition-mode, whereas string-width isn't).

Lisp programs that need 100% accuracy in these matters should call
window-text-pixel-size.



      reply	other threads:[~2021-05-27 13:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 15:56 Unicode combining characters Anand Tamariya
2021-05-25 17:22 ` Stefan Monnier
2021-05-25 17:24 ` Eli Zaretskii
2021-05-25 18:15   ` Clément Pit-Claudel
2021-05-25 18:39     ` Eli Zaretskii
2021-05-25 19:30       ` Clément Pit-Claudel
2021-05-25 19:44         ` Eli Zaretskii
2021-05-26  9:51   ` Anand Tamariya
2021-05-26 10:04     ` Joost Kremers
2021-05-26 12:54     ` Eli Zaretskii
2021-05-26 17:14       ` Eli Zaretskii
2021-05-27  7:00         ` Anand Tamariya
2021-05-27  9:40           ` Eli Zaretskii
2021-05-27 10:34             ` Basil L. Contovounesios
2021-05-27 12:30               ` Eli Zaretskii
2021-05-27 13:27             ` Anand Tamariya
2021-05-27 13:44               ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9748f5z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=atamariya@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).