From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: move_it_vertically_backward question Date: Wed, 15 Dec 2021 15:56:57 +0200 Message-ID: <83v8zqhsye.fsf@gnu.org> References: <87lf0pw78r.fsf.ref@yahoo.com> <87lf0pw78r.fsf@yahoo.com> <837dc8mue3.fsf@gnu.org> <874k7cuhv4.fsf@yahoo.com> <83lf0nl56t.fsf@gnu.org> <875yrrtiwj.fsf@yahoo.com> <837dc7l2pa.fsf@gnu.org> <87ilvqty24.fsf@yahoo.com> <87k0g6qhzx.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29669"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 15 15:39:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxVRK-0007X0-6W for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Dec 2021 15:39:30 +0100 Original-Received: from localhost ([::1]:35414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxVRI-00071I-Hv for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Dec 2021 09:39:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxUmT-0003k9-DJ for emacs-devel@gnu.org; Wed, 15 Dec 2021 08:57:17 -0500 Original-Received: from [2001:470:142:3::e] (port=49624 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxUmT-0000Ik-3x; Wed, 15 Dec 2021 08:57:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xcVNH3Ps5sPe4YzbK7eInuvp7ELL9IpLsXBzgQuA6LU=; b=RDyP4YIRxYw/ 5ifU7fIANg/F5177VGTQxP0HUFsHF36X9JIu2Ka0EfdM5EXJZxknmSGeiKkW8qfifoyD5MYqnSdVU Z2uQeRN3LwbxIbjbSBYJ1uQVW54r038gmsxABoeZpqwlcEQOMuPawzcPRYrjS6wDATBV7Q++Vh9ci MqyUxsg2wP+qTWsS2syMOHAzyGegOHExouBK670zVWl1r4fo+kofW2zaNm5++JOohsxc5LSKhOpjR Ih0Fyl7VzUTME1nEFfnYXhNuCC00LGrCfzsVrYfQWr5Sg2yiIZHvpH5yQfBps4yHuseMab31Ge2kj jsUhUpXsVnDfYEfishdL8g==; Original-Received: from [87.69.77.57] (port=3924 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxUmS-0003tY-Qm; Wed, 15 Dec 2021 08:57:17 -0500 In-Reply-To: <87k0g6qhzx.fsf@yahoo.com> (message from Po Lu on Wed, 15 Dec 2021 18:28:50 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282047 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Wed, 15 Dec 2021 18:28:50 +0800 > > Po Lu writes: > > > Something like this: > > > > move_it_vertically_backward (&it, pix); > > > > while (-it.current_y < pix) > > { > > last_y = it.current_y; > > move_it_vertically_backward (&it, pix + it.current_y); > > > > if (it.current_y == last_y) > > break; > > } > > BTW, if this will work, I'd like to install this primitive along with > the modification to the precision scrolling code that makes use of it > as-is, at least as a temporary solution to the performance issues until > we can decide which primitive to move its functionality into. I would like our primitives to be sufficiently general and generic to justify their existence. I'm not sure I understand what exactly would you like to install, but the original code you posted is definitely unfit for being a primitive (too specific to pixel-scroll-precision-mode), and given the unfinished discussion of whether window-text-pixel-size could do the job, I think it's very probable that we are not yet ready to seriously talk about what should be installed. So I suggest to continue discussing window-text-pixel-size until we understand completely your needs on the one hand, and what can be done by extending window-text-pixel-size on the other hand. Then we will be able to make the decision. Thanks.