From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 6d3608be88: Seccomp: improve support for newer versions of glibc (Bug#51073) Date: Mon, 24 Jan 2022 14:53:42 +0200 Message-ID: <83v8y9jnvt.fsf@gnu.org> References: <164286838577.8429.4021499312049157333@vcs2.savannah.gnu.org> <20220122161946.44098C0DA30@vcs2.savannah.gnu.org> <877daqq9kp.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 24 14:01:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nByyj-0003Hx-NV for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jan 2022 14:01:49 +0100 Original-Received: from localhost ([::1]:40568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nByyi-0002IH-N1 for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jan 2022 08:01:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nByr8-0008HY-59 for emacs-devel@gnu.org; Mon, 24 Jan 2022 07:53:58 -0500 Original-Received: from [2001:470:142:3::e] (port=35624 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nByr7-0007nW-Mv; Mon, 24 Jan 2022 07:53:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sk5pdESQbs7gr9cMl2OsM++uM9kdvKWiwiTkqLXo2n0=; b=DKLpn2LKImqf Ir1OJtjQ2Y8MJ1hLWSUqGWSEXysxT9MfG/i1S+V1okkWgUBqZuKKbRq0RHfepBTIzwTamcfEd7D8C A3/ThTgOgEjwqoCE7BipPdFWE1lxhdm6w/YpIYSxfOzFBngfYMY7g0YmvaEZOLt4pRgahf4/Q2/Bm ze/uWnXhrMn/hSeti1khLq3JeIpPF/c/eqtv2WnFMzLPQg1y2duwCN+t2Ekntr/W97Q2O/a4UkCba dhSjIgwfNHaqQexNG+UmnWEStdXzUuVgQeHHojtZ1B/UAfVBxNtUq7FgaFXd4Kos9yD4dZ0VxuDAX xWmdlUOI8USpkoloZ0rbxQ==; Original-Received: from [87.69.77.57] (port=1844 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nByr6-0006qQ-GM; Mon, 24 Jan 2022 07:53:57 -0500 In-Reply-To: (message from Philipp Stephani on Mon, 24 Jan 2022 11:44:34 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285302 Archived-At: > From: Philipp Stephani > Date: Mon, 24 Jan 2022 11:44:34 +0100 > Cc: Philipp Stephani , Emacs developers > > Am Mo., 24. Jan. 2022 um 01:09 Uhr schrieb Po Lu : > > > > Philipp Stephani writes: > > > > > branch: emacs-28 > > > commit 6d3608be88e1b30d2d10ee81f14dd485275c20ff > > > Author: Philipp Stephani > > > Commit: Philipp Stephani > > > > > > Seccomp: improve support for newer versions of glibc (Bug#51073) > > > > > > * lib-src/seccomp-filter.c (main): Allow 'pread64' and 'faccessat2' > > > system calls. Newer versions of glibc use these system call (starting > > > with commits 95c1056962a3f2297c94ce47f0eaf0c5b6563231 and > > > 3d3ab573a5f3071992cbc4f57d50d1d29d55bde2, respectively). > > > > This seems to break the build for many people running older glibc > > versions. > > I forgot to bump the minimum libseccomp version. I've done that now > (commit c34d06e3d75bfbea2605e3ae292850175ce5c235). Why do we need this and the previous change on the release branch? There were zero complaints until now about seccomp for Emacs 28. Can we revert the original change in the first place?