From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Thu, 03 Mar 2022 20:19:31 +0200 Message-ID: <83v8wuj3v0.fsf@gnu.org> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11799"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 03 19:21:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPq4Y-0002xc-Qn for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Mar 2022 19:21:07 +0100 Original-Received: from localhost ([::1]:59468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPq4X-0008M0-N7 for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Mar 2022 13:21:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPq34-00076q-9O for emacs-devel@gnu.org; Thu, 03 Mar 2022 13:19:34 -0500 Original-Received: from [2001:470:142:3::e] (port=55416 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPq33-0006b5-IT; Thu, 03 Mar 2022 13:19:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9aw9wod8qRhFHUy/uQKoOK4H4u4gVZsLFzF6vnCZavY=; b=RPH7soin0JB9 t1ZDx0ykmbm91LyQRyNnQzDrb4UJwVXW8jNrXo3KiPOe6ICYOhTt4Sw1qsWyi7YLGhOJc/fa+TRPz MFSP9i0iGi8B8EZJmdlEaE0GIqAdPXi4eMpe7qqNPzK99T5wn8RqVEBn21iMaOjeUsSHq7iyv00+U 0o+7WVZmSFdAMkiq6B/Fmnou7mlzLzRcbLNorZk1mNGCp44pspHxIA/R6pYv2P7m/U96W0Gl/6dC5 zeveXoqZGSJi40V3bx95inM8INGVL+0z1Dr66wTivXxqcHqxrVAOcTslxHEvIdSY+u0OiAkQDpHvB srqGfyXMQp3SnVug0Hr+JA==; Original-Received: from [87.69.77.57] (port=2127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPq31-00077n-Rj; Thu, 03 Mar 2022 13:19:33 -0500 In-Reply-To: <87v8wvkk64.fsf@red-bean.com> (message from Karl Fogel on Thu, 03 Mar 2022 11:41:55 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286794 Archived-At: > From: Karl Fogel > Date: Thu, 03 Mar 2022 11:41:55 -0600 > Cc: emacs-devel > > On 03 Mar 2022, Manuel Giraud wrote: > >Here is a patch that I think fix the default > >`bookmark-bmenu-list' > >sorting when `bookmark-sort-flag' is nil. > > This looks correct to me. Thank you for the fix. I'm testing it > now on 'emacs-28' and 'master' (it should behave the same on both, > of course, but might as well make sure). Assuming it behaves as > expected, I'll apply using 'git patch' on the emacs-28 branch. Please don't install new features on the release branch.