From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Avoid recording chars when reading passwords Date: Mon, 20 Jun 2022 18:52:17 +0300 Message-ID: <83v8svl4cu.fsf@gnu.org> References: <87edzz8dzo.fsf@elite.giraud> <834k0v5f7z.fsf@gnu.org> <8735g7vb47.fsf@elite.giraud> <83bkuvtr3q.fsf@gnu.org> <83tu8nrvdb.fsf@gnu.org> <87ilp2z7a4.fsf@elite.giraud> <83bkuqnrwa.fsf@gnu.org> <877d5ep5u3.fsf@disroot.org> <874k0ip5nj.fsf@disroot.org> <87wndbmzax.fsf@elite.giraud> <83czf3mv56.fsf@gnu.org> <87ilovxsl6.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: akib@disroot.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 20 17:54:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3Jjh-0007yP-Bh for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Jun 2022 17:54:45 +0200 Original-Received: from localhost ([::1]:48428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3Jjg-0000Ga-CD for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Jun 2022 11:54:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Jha-0006EH-QT for emacs-devel@gnu.org; Mon, 20 Jun 2022 11:52:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3JhZ-0007RQ-6F; Mon, 20 Jun 2022 11:52:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=trMuUAc/tx82tikCc1I/NUvS/epwIVFXwZ8AnZk9usc=; b=aNWTt1amG9pq FMWUHEFmDEUMgxbzD4GXtBr12u3f7/wCrr0RjfNblEWkFMUfnLjmD1aauZ6uCu511jguGy+uDKlT7 wkHVbZGasLRCfWqcydFOtoLDERsIp1SSGx8IYjxRkfGM9ydG8L+PQ+5zkD79hnXdHMSDDCmGbHPZs VtcmuvdIq18Dq//OdXs6tousp83cPWTei9kK8RdaN2x9eimHfy6FurvrSRNze+khT/UaI/rEb7sUw oUxBMN5LyeQG1y/tCt4spZsEcdn/UVkiNjz5/QFDj9OlSm8zUINzAMSE+jU4JJVPVd4jvmoB+f/v8 UDGhCfu1gUrm22DfEnhwHQ==; Original-Received: from [87.69.77.57] (port=4717 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3JhY-00084V-LA; Mon, 20 Jun 2022 11:52:32 -0400 In-Reply-To: <87ilovxsl6.fsf@elite.giraud> (message from Manuel Giraud on Mon, 20 Jun 2022 17:28:05 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291471 Archived-At: > From: Manuel Giraud > Cc: akib@disroot.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Mon, 20 Jun 2022 17:28:05 +0200 > > Ok. Here is an updated version of the patch. Thanks. Two minor nits (but you don't have to submit another patch, this will be fixed when installing): > +** New user option 'record-all-keys'. > +If non-nil, this option will force recording of all input keys > +including in passwords prompt (this was the previous behaviour). It > +now defaults to NIL and inhibits recording of passwords. ^^^ We use 'nil' (lower-case, without the quotes). Also, the "now" part is redundant. > + DEFVAR_BOOL ("record-all-keys", record_all_keys, > + doc: /* Non-nil means to record all typed keys. When > +nil, only passwords' keys are not recorded. */); The first line of a doc string should be a single complete sentence (for the benefit of help commands, like 'apropos', which only show the first lines).